Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rule Proposal: Feed-wide error given certain threshold of scheduled Trips not being accounted for in Vehicle Positions feed #159

Open
evansiroky opened this issue Aug 3, 2022 · 0 comments
Labels
GTFS(-rt) best practice clarification GTFS RT Best Practices Used for issues or pull requests related to GTFS RT Best Practices new rule

Comments

@evansiroky
Copy link

evansiroky commented Aug 3, 2022

Summary:

An error should be raised whenever a "vast majority" of Trips that should be in service at the time a Trip Update feed was downloaded are not accounted for in the given VehiclePosition records in the Vehicle Positions feed after accounting for canceled trips noted in the Trip Updates feed.

Steps to reproduce:

Given a TripUpdate dataset
and a Vehicle Positions dataset downloaded close to the same time as the TripUpdate dataset
and their associated GTFS Schedule dataset
When the validator has compiled a list of all trips that should be currently in service
and has scanned through all TripUpdate entities in a Trip Updates feed to determine which trips have been canceled
and has scanned through all VehiclePosition entities in a Vehicle Positions feed
and does not find a "vast majority" of Trips that were expected to be in service and that were not cancelled or not being accounted for in the VehiclePosition records
Then the validator should raise an overall flag that the Vehicle Positions feed as a whole did not have a "vast majority" of Trips being accounted for in the Vehicle Positions feed.

Expected behavior:

The GTFS-Realtime Best Practices state:

Feeds should cover the vast majority of trips included in the companion static GTFS dataset. In particular, it should include data for high-density and high-traffic city areas and busy routes.

The GTFS Validator should flag when the "vast majority" of Trips were not accounted for at the time that the trips should have been in service.

Observed behavior:

An error or warning is not raised for this problem at this time.

etc

@holly-g holly-g moved this from New Requests to Prioritized Backlog (sorted) in Data Services: External Contributions Sep 30, 2022
@holly-g holly-g moved this from Prioritized Backlog (sorted) to Current Sprint in Data Services: External Contributions Oct 5, 2022
@holly-g holly-g moved this from Current Sprint to Blocked in Data Services: External Contributions Oct 5, 2022
@holly-g holly-g moved this from Blocked to Next Sprint in Data Services: External Contributions Feb 2, 2023
@holly-g holly-g moved this from Next Sprint to Prioritized Backlog (sorted) in Data Services: External Contributions Feb 2, 2023
@e-lo e-lo added new rule GTFS RT Best Practices Used for issues or pull requests related to GTFS RT Best Practices GTFS(-rt) best practice clarification labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GTFS(-rt) best practice clarification GTFS RT Best Practices Used for issues or pull requests related to GTFS RT Best Practices new rule
Projects
None yet
Development

No branches or pull requests

2 participants