Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rule Proposal: warning for missing file modification date #172

Open
owades opened this issue Feb 17, 2023 · 2 comments
Open

New Rule Proposal: warning for missing file modification date #172

owades opened this issue Feb 17, 2023 · 2 comments

Comments

@owades
Copy link

owades commented Feb 17, 2023

Summary:

New rule: Check whether each RT feed header includes file modification date, as per the following best practice:

The web-server hosting GTFS Realtime data should be configured to correctly report the file modification date (see HTTP/1.1 
- Request for Comments 2616, under Section 14.29) so consumers can leverage the If-Modified-Since HTTP header. This 
saves producers and consumers bandwidth by avoiding transferring feed contents that haven't changed.

Severity: Warning

Expected behavior:

If the file modification date header is not present for any RT feed, throw a warning.

@owades owades changed the title New rule: warning for missing file modification date New Rule Proposal: warning for missing file modification date Feb 17, 2023
@briandonahue
Copy link

Investigating this. Currently validation does not begin until after the file is downloaded locally, therefore the request header information is not available. Will discuss possible implementations with @KClough and update the issue once we've determined an approach.

@briandonahue
Copy link

@bdferris-v2 It seems I can check for this in BackgroundTask.java where the request is made, but I'm looking for feedback on if/how to store that as metadata to validate and generate a notice during the validation phase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants