From 4029a3741ce6b743f6eae2bc13dd16313fbad557 Mon Sep 17 00:00:00 2001 From: Emma Blue <90632321+emmambd@users.noreply.github.com> Date: Wed, 13 Mar 2024 13:29:20 -0400 Subject: [PATCH] feat: Add examples table for mixed_case_recommended_field (#1708) * add table * fix table to match #1695 * fix java doc error * update caption styles * web ui style update + add colons --------- Co-authored-by: David Gamez Diaz <1192523+davidgamez@users.noreply.github.com> Co-authored-by: Jingsi Lu --- .../MixedCaseRecommendedFieldNotice.java | 36 ++++++++++++++++++- main/src/main/resources/report.html | 5 +++ web/client/src/css/components/markdown.css | 5 ++- 3 files changed, 44 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/org/mobilitydata/gtfsvalidator/notice/MixedCaseRecommendedFieldNotice.java b/core/src/main/java/org/mobilitydata/gtfsvalidator/notice/MixedCaseRecommendedFieldNotice.java index cf98007ca3..011030021c 100644 --- a/core/src/main/java/org/mobilitydata/gtfsvalidator/notice/MixedCaseRecommendedFieldNotice.java +++ b/core/src/main/java/org/mobilitydata/gtfsvalidator/notice/MixedCaseRecommendedFieldNotice.java @@ -15,7 +15,41 @@ * (e.g. “JFK Airport”). Abbreviations may be problematic for accessibility by screen reader * software and voice user interfaces. * - * @see org.mobilitydata.gtfsvalidator.annotation.MixedCase + * + * + * + * + * + * + * + * + * + * + * + * + * + * + * + * + * + * + *
Good examples:
Field TextDataset
"Schwerin, Hauptbahnhof"Verkehrsverbund Berlin-Brandenburg
"Red Hook/Atlantic Basin"NYC Ferry
"Campo Grande Norte"Carris
+ * + * + * + * + * + * + * + * + * + * + * + * + * + * + * + *
Bad examples:
Field Text
"GALLERIA MALL"
"3427 GG 17"
"21 Clark Rd Est"
*/ @GtfsValidationNotice( severity = WARNING, diff --git a/main/src/main/resources/report.html b/main/src/main/resources/report.html index 88cda2be8c..fa06e86da2 100644 --- a/main/src/main/resources/report.html +++ b/main/src/main/resources/report.html @@ -43,6 +43,11 @@ width: 100%; } + table caption { + text-align: left; + margin: 0.5em 0; + } + table th { text-align: left; border-bottom: 2px solid #000; diff --git a/web/client/src/css/components/markdown.css b/web/client/src/css/components/markdown.css index a541565c37..db4ce8e20a 100644 --- a/web/client/src/css/components/markdown.css +++ b/web/client/src/css/components/markdown.css @@ -63,9 +63,12 @@ table { @apply my-2; + caption { + @apply text-left; + } } - th, td { + th, td, { @apply align-baseline; @apply px-4 py-3; @apply text-left;