Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement feed dates verification (GTFS rule) #140

Open
maximearmstrong opened this issue Apr 29, 2020 · 1 comment
Open

Implement feed dates verification (GTFS rule) #140

maximearmstrong opened this issue Apr 29, 2020 · 1 comment
Labels
community rules This is used for Out of Spec / Out of Best Practice rules that we'd like to include in the validator new rule New rule to be added python validator Rules implemented in the original Google Python Validator status: Needs discussion We need a discussion on requirements before calling this issue ready
Milestone

Comments

@maximearmstrong
Copy link
Contributor

maximearmstrong commented Apr 29, 2020

Is your feature request related to a problem? Please describe.
A feed must have dates linked to it, and must have exceptions for specific dates (trips exceptions, different route, etc.). This is a GTFS rule implemented in Google Python validator and featured in Google Type Error as TYPE_FEED_HAS_NO_SERVICE_DATE_EXCEPTIONS and TYPE_FEED_HAS_NO_SERVICE_DATES.

Describe the solution you'd like
Actual Google GTFS validator behaviour : verifies if feed has effective dates (if empty or is in a valid date format), then verifies service gaps and service exception. Verifies if a feed has exceptions, if the feed has been active for over 6 months.

Describe alternatives you've considered

Additional context
Line 52 et 53 in Error support priorities https://docs.google.com/spreadsheets/d/1vqe6wq7ctqk1EhYkgtZ0_TbcQ91vccfs2daSjn20BLE/edit#gid=0

@maximearmstrong maximearmstrong added the python validator Rules implemented in the original Google Python Validator label Jun 9, 2020
@ghost ghost added the outofspec label Jul 21, 2020
@Cristhian-HA Cristhian-HA changed the title [REQUEST] Implement feed dates verification (GTFS rule) Implement feed dates verification (GTFS rule) Dec 16, 2020
@lionel-nj lionel-nj added community rules This is used for Out of Spec / Out of Best Practice rules that we'd like to include in the validator and removed new rule labels Jun 16, 2021
@isabelle-dr isabelle-dr added new rule New rule to be added status: Needs discussion We need a discussion on requirements before calling this issue ready labels Oct 3, 2022
@isabelle-dr
Copy link
Contributor

We usually don't add rules that are not clearly specified in the spec or best practices (this is the case here), but we make exceptions for what the community thinks is valuable to check (point_near_origin, fast_travel_between_consecutive_stops, unused_trip, just to name a few).
This is done on a case-by-case basis, by discussing with the community.
We are in favor of having the spec modified first before adding the check in the validator.

@isabelle-dr isabelle-dr added this to the Future work milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community rules This is used for Out of Spec / Out of Best Practice rules that we'd like to include in the validator new rule New rule to be added python validator Rules implemented in the original Google Python Validator status: Needs discussion We need a discussion on requirements before calling this issue ready
Projects
None yet
Development

No branches or pull requests

4 participants