Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement minimum transfer time verification #159

Open
maximearmstrong opened this issue May 4, 2020 · 4 comments
Open

Implement minimum transfer time verification #159

maximearmstrong opened this issue May 4, 2020 · 4 comments
Labels
community rules This is used for Out of Spec / Out of Best Practice rules that we'd like to include in the validator new rule New rule to be added python validator Rules implemented in the original Google Python Validator status: Blocked Can't work on it currently because of an external factor.
Milestone

Comments

@maximearmstrong
Copy link
Contributor

maximearmstrong commented May 4, 2020

Is your feature request related to a problem? Please describe.
Minimum transfer time should be present and valid. This is a GTFS rule implemented in Google Python validator and featured in Google Type Error as TYPE_TRANSFER_MIN_TRANSFER_TIME_AND_INVALID_TYPE, TYPE_TRANSFER_MIN_TRANSFER_TIME_IS_MISSING, TYPE_TRANSFER_MIN_TRANSFER_TIME_IS_NEGATIVE and TYPE_TRANSFER_MIN_TRANSFER_TIME_IS_VERY_LARGE.

Describe the solution you'd like
Actual Google GTFS validator behaviour : verifies if minimum transfer time is not missing, if it's not negative, nor equal or greater than 24h.

Describe alternatives you've considered

Additional context
Line 124, 125, 126 and 127 in Error support priorities https://docs.google.com/spreadsheets/d/1vqe6wq7ctqk1EhYkgtZ0_TbcQ91vccfs2daSjn20BLE/edit#gid=0

@barbeau
Copy link
Member

barbeau commented May 7, 2020

This is another rule that may need to be configurable - the "not greater than 24 hrs" doesn't appear in the spec or best practices:

It's worth noting that the best practices say:

1: This is a timed transfer point between two routes. The departing vehicle is expected to wait for the arriving one, with sufficient time for a passenger to transfer between routes.This transfer type overrides a required interval to reliably make transfers. As an example, Google Maps assumes that passengers need 3 minutes to safely make a transfer. Other applications may assume other defaults.

@maximearmstrong maximearmstrong changed the title [REQUEST] Implement minimum transfer time verification (GTFS rule) [REQUEST] Implement minimum transfer time verification May 11, 2020
@maximearmstrong
Copy link
Contributor Author

@barbeau @timMillet Should every threshold verified by the Python validator be treated as warnings in our validator? Therefore not a GTFS error, but still verifying the Python validator rules.

@barbeau
Copy link
Member

barbeau commented May 11, 2020

@maximearmstrong IMHO it should be considered on a case-by-case basis. The problem with labeling rules as warnings is that some producers tend to ignore everything that's not an error. If there are clear, common cases of bad data IMHO it makes sense to have an error for a threshold. The (0,0) bus stop location is one example. Some (like this min transfer time rule) may be a bit fuzzier and require some discussion in the community of what an error threshold should be. One data-driven approach is to programmatically examine all the feds from OpenMobilityData.org and pick the 95th percentile as the error threshold.

@lionel-nj
Copy link
Contributor

We are considering making numeric thresholds user configurable to notice producers that although the data is syntactically correct (here min_transfer_time >0), the value is too small or too big.

See related comments: #71 (comment)

@maximearmstrong maximearmstrong added the python validator Rules implemented in the original Google Python Validator label Jun 9, 2020
@lionel-nj lionel-nj self-assigned this Jun 30, 2020
@ghost ghost added the outofspec label Jul 21, 2020
@Cristhian-HA Cristhian-HA changed the title [REQUEST] Implement minimum transfer time verification Implement minimum transfer time verification Dec 16, 2020
@lionel-nj lionel-nj added community rules This is used for Out of Spec / Out of Best Practice rules that we'd like to include in the validator and removed new rule labels Jun 16, 2021
@isabelle-dr isabelle-dr added status: Blocked Can't work on it currently because of an external factor. new rule New rule to be added labels Oct 3, 2022
@isabelle-dr isabelle-dr added this to the Future work milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community rules This is used for Out of Spec / Out of Best Practice rules that we'd like to include in the validator new rule New rule to be added python validator Rules implemented in the original Google Python Validator status: Blocked Can't work on it currently because of an external factor.
Projects
None yet
5 participants