Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with how the route_long_name_contains_short_name description renders on the HTML report #1624

Closed
isabelle-dr opened this issue Dec 20, 2023 · 1 comment · Fixed by #1669
Closed

Problem with how the route_long_name_contains_short_name description renders on the HTML report #1624

isabelle-dr opened this issue Dec 20, 2023 · 1 comment · Fixed by #1669
Assignees
@qcdyx
Labels
bug Something isn't working (crash, a rule has a problem) good first issue Good task for newcomers to work on.

Comments

@isabelle-dr
Copy link
Contributor

isabelle-dr commented Dec 20, 2023 •
edited by emmambd
Loading

Describe the bug

The HTML report displays the description of the notices, that I believe are taken directly from our documentation.

This particular rule has a table showing good and bad examples, and it doesn't render properly on the HTML report.

Steps/Code to Reproduce

I used Entur's dataset for the entire Norway for this report ( a little patience is needed if you'd like to reproduce 😊).

Other example that's not as large:

Report example
Feed URL: https://dipl.nt.gov.au/data-feeds/bus-gtfs/google-transit-darwin.zip?v=0.16.0
Validate the data, and expand the route_long_name_contains_short_name notice.

Expected Results

Something in a table format like this:
Screenshot 2023-12-20 at 2 01 01 PM

Actual Results

Screenshot 2023-12-20 at 2 02 15 PM

Screenshots

No response

Files used

No response

Validator version

4.2.1

Operating system

MacOS

Java version

No response

Additional notes

No response
@isabelle-dr isabelle-dr added bug Something isn't working (crash, a rule has a problem) status: Needs triage Applied to all new issues labels Dec 20, 2023
@github-project-automation github-project-automation bot moved this to Requires investigation in Bug triage Dec 20, 2023
@emmambd emmambd moved this to MobilityData Backlog (bugs & maintenance) in Schedule Validator Q2 backlog Jan 5, 2024
@emmambd emmambd added status: Ready An issue that is ready to be worked on. and removed status: Needs triage Applied to all new issues labels Jan 5, 2024
@emmambd emmambd added this to the Now milestone Jan 9, 2024
@emmambd emmambd added the good first issue Good task for newcomers to work on. label Jan 9, 2024
@qcdyx qcdyx removed the status: Ready An issue that is ready to be worked on. label Feb 9, 2024
@qcdyx
Copy link
Contributor

qcdyx commented Feb 12, 2024

It seems like we need to reexamine the format of the notices that contains examples
image

@qcdyx qcdyx mentioned this issue Feb 12, 2024
Merged
5 tasks
@qcdyx qcdyx linked a pull request Feb 12, 2024 that will close this issue
fix: reformatted doc using HTML table format #1669
Merged
5 tasks
@jcpitre jcpitre mentioned this issue Feb 13, 2024
Closed
@github-project-automation github-project-automation bot moved this from MobilityData Backlog (bugs & maintenance) to Done in Schedule Validator Q2 backlog Feb 14, 2024
@github-project-automation github-project-automation bot moved this from Requires investigation to Done in Bug triage Feb 14, 2024
@emmambd emmambd removed this from the Now milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qcdyx qcdyx

Labels
bug Something isn't working (crash, a rule has a problem) good first issue Good task for newcomers to work on.
Projects
Bug triage
Status: Done
Schedule Validator Q2 backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reformatted doc using HTML table format MobilityData/gtfs-validator
3 participants
@qcdyx @isabelle-dr @emmambd