Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flex: invalid_prior_notice_duration_min #1828

Closed
emmambd opened this issue Sep 9, 2024 · 1 comment · Fixed by #1860
Closed

Flex: invalid_prior_notice_duration_min #1828

emmambd opened this issue Sep 9, 2024 · 1 comment · Fixed by #1860
Assignees
@cka-y
Labels
new rule New rule to be added
Milestone
6.0 Validator Rel...

Comments

@emmambd
Copy link
Contributor

emmambd commented Sep 9, 2024 •
edited
Loading

Describe the problem

See below

Describe the new validation rule

invalid_prior_notice_duration_min as defined in the table here

Sample GTFS datasets

Severity

Error

Additional context

No response
@emmambd emmambd added status: Needs triage Applied to all new issues new rule New rule to be added labels Sep 9, 2024
@emmambd emmambd added this to the 7.0 Validator Release milestone Sep 9, 2024
@qcdyx
Copy link
Contributor

qcdyx commented Sep 24, 2024 •
edited
Loading

Tasks:

  • add the logic and create a new notice
  • add tests
  • review auto-generated documentation
  • review acceptance tests

@cka-y cka-y self-assigned this Sep 25, 2024
@cka-y cka-y removed the status: Needs triage Applied to all new issues label Sep 25, 2024
@cka-y cka-y linked a pull request Oct 1, 2024 that will close this issue
feat: added forbidden_prior_day_booking_field_value, invalid_prior_notice_duration_min and forbidden_prior_notice_start_day notices #1860
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cka-y cka-y

Labels
new rule New rule to be added
Projects
None yet
Milestone
6.0 Validator Release
3 participants
@qcdyx @cka-y @emmambd