Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex: modify stop_without_stop_time to exclude stops associated with a used location_group #1883

Closed
emmambd opened this issue Oct 9, 2024 · 2 comments · Fixed by #1887
Closed
Assignees
Labels
enhancement New feature request or improvement on an existing feature

Comments

@emmambd
Copy link
Contributor

emmambd commented Oct 9, 2024

Describe the problem

Based on the acceptance test changes from #1834 (comment), there are changes in fixed stop demand responsive services where a stop_id will not be referenced explicitly in stop_times.txt and therefore would generate the stop_without_stop_time warning, even though the stop_id is technically used.

Proposed solution

Create an exception for this rule:

If there's a location_group_id referenced in stop_times.txt, go through the original location_group file and check all the stops associated with that id. If a stop exists in the location_group that is being used in stop_times, don't trigger the warning.

Alternatives you've considered

No response

Additional context

No response

@emmambd emmambd added the enhancement New feature request or improvement on an existing feature label Oct 9, 2024
@emmambd emmambd added this to the 6.0 Validator Release milestone Oct 9, 2024
@qcdyx qcdyx self-assigned this Oct 10, 2024
@qcdyx
Copy link
Contributor

qcdyx commented Oct 10, 2024

stop_id can be referenced directly or indirectly
check if stop_id is referenced
if not, check if location_group_id is referenced
if stop is a part of location_group, it can be referenced
in one entry, you can reference only 1

@qcdyx
Copy link
Contributor

qcdyx commented Oct 11, 2024

Hey @emmambd could you provide a test feed please? I tried some datasets based on #1834 (comment), no luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or improvement on an existing feature
Projects
None yet
2 participants