Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice invalid_input_files_in_subfolder not triggered if zip file and subfolder have the same name #1912

Open
praneethd7 opened this issue Oct 28, 2024 · 1 comment · May be fixed by #1972
Labels
bug Something isn't working (crash, a rule has a problem) good first issue Good task for newcomers to work on. status: Needs triage Applied to all new issues

Comments

@praneethd7
Copy link
Contributor

Describe the bug

As the title says. Currently, the notice invalid_input_files_in_subfolder is not triggered when the zip file (without .zip) and the sub folder have the same name.

Possible Reason:
The condition is not satisfied here and the notice is not raised

if (containsSubfolder && entryName.contains(subfolder) && entryName.endsWith(".txt")) {

Steps/Code to Reproduce

Example Case [has subfolder piercetransit-wa-us--flex-v2]:
piercetransit-wa-us_zip.zip - Will raise the notice
piercetransit-wa-us--flex-v2.zip - Does not raise the notice

Expected Results

Image

Actual Results

Image

Screenshots

No response

Files used

No response

Validator version

6.0.0

Operating system

Windows

Java version

No response

Additional notes

No response

@praneethd7 praneethd7 added bug Something isn't working (crash, a rule has a problem) status: Needs triage Applied to all new issues labels Oct 28, 2024
@github-project-automation github-project-automation bot moved this to Requires investigation in Bug triage Oct 28, 2024
@emmambd emmambd added this to the 7.0 Validator Release milestone Oct 28, 2024
@qcdyx qcdyx removed this from the 7.0 Validator Release milestone Dec 9, 2024
@emmambd emmambd added the good first issue Good task for newcomers to work on. label Feb 5, 2025
sylvansson added a commit to sylvansson/gtfs-validator that referenced this issue Feb 6, 2025
@sylvansson sylvansson linked a pull request Feb 6, 2025 that will close this issue
5 tasks
@sylvansson
Copy link
Contributor

Hi @praneethd7, I looked into this and I think the filename was a red herring. I shared some findings in #1972. Were both of your ZIP files created the same way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (crash, a rule has a problem) good first issue Good task for newcomers to work on. status: Needs triage Applied to all new issues
Projects
Status: Requires investigation
Development

Successfully merging a pull request may close this issue.

4 participants