Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger warning for duplicated stop_code #471

Open
antrim opened this issue Oct 29, 2020 · 5 comments
Open

Trigger warning for duplicated stop_code #471

antrim opened this issue Oct 29, 2020 · 5 comments
Labels
community rules This is used for Out of Spec / Out of Best Practice rules that we'd like to include in the validator new rule New rule to be added status: Blocked Can't work on it currently because of an external factor.
Milestone

Comments

@antrim
Copy link

antrim commented Oct 29, 2020

stops.stop_code is a free text field for passenger-facing IDs. In most cases, stop_code needs to be unique in a dataset. (There may be some exceptions, for example, if stops within a station all share the same ID?)

Requested solution:
Warnings on non-unique stop_code values.

Related: "[REQUEST] Implement unique Stop ID verification (GTFS Rule)" #230

@LeoFrachet
Copy link

Hi Aaron,

Alas, such thing varies a lot among data producers. I agree that this warning could be useful for many producers. But for another large set of data producers, stop codes are not unique, and it will be just generate a long list of warning that people will start ignoring.

I would therefore advocate to not apply such validation by default, and to not generate such warning.

If there is a large need in a specific part of the industry, we invite this part of the industry to contribute in kind as an op-in validation rule.

Thanks!

@LeoFrachet LeoFrachet changed the title [REQUEST] [REQUEST] Trigger warning for duplicated stop_code Nov 9, 2020
@e-lo
Copy link

e-lo commented Nov 9, 2020

We invite this part of the industry to contribute in kind as an op-in validation rule

What is the framework for parameterizing what rules are called?

@LeoFrachet
Copy link

By default it's only spec.
We can opt-in for more strict rules, with parameters passed in a JSON, like "Add Google rules". And therefore we invite stakeholders to add additional rules if they want and to define set of rules that they deeamed important. It is mostly useful for data consumers set of rules, but if Trillium wnats to define "Trillium rules" set they can.

@antrim
Copy link
Author

antrim commented Nov 9, 2020

By default it's only spec.

What about https://gtfs.org/best-practices/ ?

@Cristhian-HA Cristhian-HA changed the title [REQUEST] Trigger warning for duplicated stop_code Trigger warning for duplicated stop_code Dec 16, 2020
@barbeau barbeau added this to the Future work milestone Jan 21, 2021
@isabelle-dr
Copy link
Contributor

isabelle-dr commented Jul 7, 2021

Hello,

Two pieces of information to add here:

  1. What about https://gtfs.org/best-practices/ ?

    -> They are planned on being part of the Canonical GTFS Schedule Validator.

  2. We are working on updating the validator to be able to add a rule that is specific to one stakeholder. A user will then be able to validate against it via a command-line parameter.
    Would you agree to participate by having a Trillium "profile" and adding a warning for duplicated stop_code under it @antrim?

@isabelle-dr isabelle-dr added the community rules This is used for Out of Spec / Out of Best Practice rules that we'd like to include in the validator label Aug 6, 2021
@isabelle-dr isabelle-dr modified the milestones: Future work, Rules improvements Jan 9, 2022
@isabelle-dr isabelle-dr added the new rule New rule to be added label Sep 16, 2022
@isabelle-dr isabelle-dr added the status: Blocked Can't work on it currently because of an external factor. label Oct 3, 2022
@isabelle-dr isabelle-dr modified the milestones: Rules improvements, Future work Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community rules This is used for Out of Spec / Out of Best Practice rules that we'd like to include in the validator new rule New rule to be added status: Blocked Can't work on it currently because of an external factor.
Projects
None yet
Development

No branches or pull requests

6 participants