Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove postinstall script "rm -rf ../node_modules" #103

Open
emanuelb opened this issue Aug 29, 2020 · 0 comments
Open

Remove postinstall script "rm -rf ../node_modules" #103

emanuelb opened this issue Aug 29, 2020 · 0 comments

Comments

@emanuelb
Copy link

From package.json:

"postinstall": "rm -rf ../node_modules",

it's harmful and not needed, why it's here?
if someone do (projects contain node_modules directory)

cd ./projects/
git clone --depth 1 https://github.com/MohGovIL/rn-contact-tracing/
cd rn-contact-tracing
yarn install

The node_modules in projects directory will be removed, which don't related to this repo at all.

kaplanlior added a commit that referenced this issue Aug 30, 2020
It deletes files outside of repository directories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant