Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check for existence of executables if the run requires it #13

Open
pansapiens opened this issue Feb 5, 2018 · 5 comments
Open

Comments

@pansapiens
Copy link
Contributor

Version: 1.4.8

RNAsik fails to run if bwa or hisat2 are missing, even if run won't use them based on the given commandline parameters.

eg, if -align star is specified, don't check for the existence of bwa or hisat2 executables unless they are actually required.

@serine
Copy link
Collaborator

serine commented Feb 5, 2018

yes, this is an issue. Sort of working on that issue, also put it on the road map for 1.4.10. However this is also a little bit related to @stu2 PR #6 should have it all cleaned by 1.4.10.

Thanks

@pansapiens
Copy link
Contributor Author

A hacky workaround in the meantime is to specify, in sik.config:

hisat2Exe = false
bwaExe = false

This way it finds the false executable to keep it happy.

@serine
Copy link
Collaborator

serine commented Feb 5, 2018

that's not gonna fix it, problem is in sikLog.bds file here basically I simply take a log of all dependencies irrespective whether those tools are going to be used or not.. Like I said working on making this better fix_logger branch

this isn't a bad idea trying to use false there. I'll have to think about how its going to work, just not in this case

@pansapiens
Copy link
Contributor Author

I'm aware of where the executable checks happen. Just a quick workaround users can implement easily themselves if they happen to stumble upon this issue in the meantime vs. proper fix.

@serine
Copy link
Collaborator

serine commented May 9, 2018

Comment to myself, I started fix_logger branch, going to work there to fix these issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants