We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: https://github.com/MoonSHRD/MS-Factory/blob/feat/hold/contracts/721/singleton/TicketFactory721.sol#L86 Unneccesarity conversion from wei to ether at contract side
This conversion should be done at client side
Way to solution:
remove conversion from https://github.com/MoonSHRD/MS-Factory/blob/feat/hold/contracts/721/singleton/TicketFactory721.sol#L86
refactor uint256 ta = (weiAmount / (1 ether)) / (_rate / (1 ether)); to uint256 ta = weiAmount / _rate; at https://github.com/MoonSHRD/MS-Factory/blob/feat/hold/contracts/721/singleton/TokenSale721.sol#L247
uint256 ta = (weiAmount / (1 ether)) / (_rate / (1 ether));
uint256 ta = weiAmount / _rate;
add web3.toWei conversion at client side, in moment, when we setting up price
web3.toWei
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Problem:
https://github.com/MoonSHRD/MS-Factory/blob/feat/hold/contracts/721/singleton/TicketFactory721.sol#L86
Unneccesarity conversion from wei to ether at contract side
This conversion should be done at client side
Way to solution:
remove conversion from
https://github.com/MoonSHRD/MS-Factory/blob/feat/hold/contracts/721/singleton/TicketFactory721.sol#L86
refactor
uint256 ta = (weiAmount / (1 ether)) / (_rate / (1 ether));
to
uint256 ta = weiAmount / _rate;
at
https://github.com/MoonSHRD/MS-Factory/blob/feat/hold/contracts/721/singleton/TokenSale721.sol#L247
add
web3.toWei
conversion at client side, in moment, when we setting up priceThe text was updated successfully, but these errors were encountered: