Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use version expressions for dependency declarations #114

Open
2 tasks
keturn opened this issue May 1, 2021 · 2 comments
Open
2 tasks

use version expressions for dependency declarations #114

keturn opened this issue May 1, 2021 · 2 comments
Labels
Topic: Module Requests, Issues and Changes related to gestalt modules Type: Improvement Request for or addition/enhancement of a feature

Comments

@keturn
Copy link
Member

keturn commented May 1, 2021

  • Is it worth keeping the existing VersionRange class at all, or should we convert entirely?
  • Instead of building an expression out of minVersion, should we allow module metadata to define its own expression?
    • We would need to use the Maven-style expressions in that case in order for compile-time dependency resolution to still work.

Follow-up from #101.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@keturn keturn added Type: Improvement Request for or addition/enhancement of a feature Topic: Module Requests, Issues and Changes related to gestalt modules v7 labels May 1, 2021
@keturn
Copy link
Member Author

keturn commented May 3, 2021

ah, the Maven expressions are implemented in the antilaby fork. That explains why I couldn't find them in the upstream zafarkhaja sources.

Unfortunately, the confusing incrementMajorVersion behavior is also from the antilaby fork AntiLaby/jsemver@f9fee42

"1.0.0-alpha".incrementMajorVersion() == "1.0.0"
"1.2.0-alpha".incrementMajorVersion() == "2.0.0"

without really any attached issue documentation to explain why.

@keturn
Copy link
Member Author

keturn commented May 3, 2021

here is a different implementation entirely: https://github.com/vdurmont/semver4j

Its Ivy-mode looks like it is intended to be gradle-compatible.

@jdrueckert jdrueckert removed the v7 label Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Module Requests, Issues and Changes related to gestalt modules Type: Improvement Request for or addition/enhancement of a feature
Projects
None yet
Development

No branches or pull requests

2 participants