Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to reliably detect static/animated models? #5

Open
Mugen87 opened this issue Sep 1, 2022 · 0 comments
Open

How to reliably detect static/animated models? #5

Mugen87 opened this issue Sep 1, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Mugen87
Copy link
Owner

Mugen87 commented Sep 1, 2022

It would be good to know if there is an intended way to detect whether an object is animated or not. Right now, M2Loader counts the number of bones although this approach is not robust.

three-m2loader/M2Loader.js

Lines 394 to 397 in e71c776

// TODO: Find out a better way for detecting static models
// Problem: Even static models have some bone definitions
if ( boneDefinitions.length < 8 ) return null;

@Mugen87 Mugen87 added enhancement New feature or request help wanted Extra attention is needed labels Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant