-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated values from Skills settingsmeta #1092
Comments
Hi @krisgesling , Can I take it up?? As per my understanding, some key-value pairs (name & color) needs to be removed from all the skills which will be located either in settingsmeta.json or settingsmeta.yaml file, am i right? |
That sounds exactly correct. You'll need to sign a CLA for the skills created by mycroftai so you might want to start to apply for that so the manual processing can be done while you do the work at hand. Go to https://mycroft.ai/cla to start the process :) |
Yeah that's right. Just be sure to only remove the top-level In the Date-Time Skill example, you can see this on line 2. Feel free to ask questions here if you're unsure at all. |
@krisgesling Sure Thanks i will take it. @forslund sure will sign a CLA. |
@krisgesling please check this if its right or not? |
Looks good to me. For the CLA there is one manual step in the process, but I'll follow up with the team once the US wake up again. |
@krisgesling hey there any updates?? |
With the release of 19.08, we have deprecated the Skill name and color values in Skill settings because they are no longer used by the backend.
There are many Skills that still have these values set and we need help tracking them down and updating them. They can be set in either a
settingsmeta.json
orsettingsmeta.yaml
file.An example would be the Date and Time Skill. On lines 2 and 3 of this Skills settingsmeta.json file, we can delete lines 2 and 3 that define the Skill
name
andcolor
.For each Skill you update, you will need to create a pull request (PR) back to that Skill's repository (not to mycroft-skills). Each of these PR's can count toward your Hacktoberfest goal.
🥇 If this is your first time contributing to open source - welcome and thank you 🎉
This excellent tutorial on how to make your first open source contribution is a great way to get started. But if you have any questions, please join us in the ~dev channel of Mycroft Chat 😀
The text was updated successfully, but these errors were encountered: