Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxon threshold default values in code #105

Open
martinghunt opened this issue Oct 12, 2020 · 0 comments
Open

Taxon threshold default values in code #105

martinghunt opened this issue Oct 12, 2020 · 0 comments

Comments

@martinghunt
Copy link
Member

Noting this for future in case we get bugs/want to change...

Ideally, these would be in the data download, not the code:

DEFAULT_THRESHOLD = 30
TAXON_THRESHOLDS = {
"Saureus" : 30,
"Sepidermidis" : 30,
"Shaemolyticus" : 30,
"Sother" : 15,
"Coagneg" : 30,
"Staphaureus" : 30,
"Escherichia_coli" : 15,
"Klebsiella_pneumoniae" : 15,
"Ecoli_Shigella": 90,
"Shigella_sonnei": 90,
}

(was easy to put them here when ref data got rewritten to live on figshare, but is not ideal)

Not sure if the defaults of 90 will be ok for shigella - see if we get bug reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant