-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add children-in-frustum optimization #741
Comments
Cesium's implementation updates all child frustum and error metrics before marking children as "used": It's also the case that Cesium does not unload external tile sets: |
In a test the frustum optimization improves the tile visibility from 350 to 323 so it can have quite an impact. With a more shallow approach this loads ~340 tiles on google earth tiles. The limited approach may be "good" enough - otherwise this requires keeping all tile sub trees in memory. |
It's possible we could keep the tile marked as "used" but mark "in frustum" to be false and account for that in the subsequent traversals. This would cause the tiles to still load but at least not be rendered. |
In d316413 the check for child visibility has been disabled because it can cause unused children to be added to the lru cache. We should understand why and see if we can add an easy way to check frustum visibility without marking a child as used.
The fundamental issue is that external tile sets are being marked as unused because the children aren't visible, being unloaded, then being marked as used again because there are no children and loading.
Related to #740
The text was updated successfully, but these errors were encountered: