Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TilesRenderer: Improve ergonomics of "loadProgress" #937

Closed
gkjohnson opened this issue Jan 21, 2025 · 1 comment · Fixed by #942
Closed

TilesRenderer: Improve ergonomics of "loadProgress" #937

gkjohnson opened this issue Jan 21, 2025 · 1 comment · Fixed by #942
Milestone

Comments

@gkjohnson
Copy link
Contributor

gkjohnson commented Jan 21, 2025

  • Ensure load progress is updated before "load-model" callback
  • Prevent bouncing back and forth of load progress due to in progress tiles not being added to the lru cache preemptively.
    • Possibly just this function can just be adjusted to traverse all children to ensure they are loading if "used". Then all necessary tiles will be queued immediately which will be reflected in the loadProgress field- hopefully without added overhead.
@gkjohnson gkjohnson added this to the v0.4.4 milestone Jan 21, 2025
@gkjohnson
Copy link
Contributor Author

The bouncing can't really be prevented in some cases since we can't know how many tiles will need to be loaded when an external tile set is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant