Failing CI test

[mnlevy1981]

Describe the bug
The Github Action to build and deploy the webpage is failing; it looks like actions/upload-pages-artifact@v2 relies on actions/upload-artifact@v3 which is no longer supported

To Reproduce
Nothing to reproduce, it all happens on the github VMs

Expected behavior
The "Build and Deploy" workflow should complete successfully

Additional context
I'll open a PR momentarily, I think we just need to change

-        uses: actions/upload-pages-artifact@v2
+        uses: actions/upload-pages-artifact@v3

[mnlevy1981]

#179 got past the build stage, but is now failing in deploy

[mnlevy1981]

Updating to actions/upload-pages-artifact@v3 lets the CI get past the build (where this action is used):

Artifact github-pages has been successfully uploaded!

But the deploy step can't find the artifact:

Artifact exchange URL: https://pipelinesghubeus15.actions.githubusercontent.com/r0O2PqzpZZvLADt5AEctx16a3z8nyUKq4W9djzLDGsUtyKKMMd/_apis/pipelines/workflows/13081387076/artifacts?api-version=6.0-preview
Error: Error: No uploaded artifact was found! Please check if there are any errors at build step, or uploaded artifact name is correct.
    at getSignedArtifactMetadata (/home/runner/work/_actions/actions/deploy-pages/v2/src/internal/api-client.js:94:1)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Deployment.create (/home/runner/work/_actions/actions/deploy-pages/v2/src/internal/deployment.js:68:1)
    at main (/home/runner/work/_actions/actions/deploy-pages/v2/src/index.js:30:1)
Error: Error: No uploaded artifact was found! Please check if there are any errors at build step, or uploaded artifact name is correct.

I don't see any clear documentation in the action repository about updating from v2 -> v3, though I did compare our deploy.yml file to the example given in the README and we are using actions/deploy-pages@v2 rather than actions/deploy-pages@v4... but otherwise our YAML file looks the same as their example. I found the PR where upload-artifact was updated from v3 -> v4-beta and that one includes

    outputs:
      artifact-id: ${{ steps.upload-pages-artifact.outputs.artifact-id }}

in the build block... so those are two potential changes we could make, but I don't really want to do so without a better understanding of what's going wrong and what those two changes do. @anissa111 do you use a similar action on other repositories? If so, what have you done elsewhere now that actions/upload-pages-artifact@v2 does not work?

[anissa111]

Sorry for the slow response, I only work half days Fridays currently.

I'm not sure why you're running into issues with this right off the top of my head. I haven't seen any issues on the deployments for other repos I'm watching, but none of them use a similar enough build/deploy for that to surprise me.

I have a method for testing deployment actions workflows from a personal fork; I'll see if I can fiddle with the artifact upload/download to get it aligned again.

[anissa111]

Ah! I have a fix working on my fork, I'll submit a PR.

[mnlevy1981]

Sorry for the slow response, I only work half days Fridays currently.

No worries, sorry to flood your inbox when it was already the weekend :)

Ah! I have a fix working on my fork, I'll submit a PR.

Awesome, thanks so much!!!

[mnlevy1981]

Fixed by #181 (with an assist from #179 😄)