Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress data being sent to Appraiser #683

Closed
MarkDWilliams opened this issue Sep 12, 2024 · 3 comments
Closed

Compress data being sent to Appraiser #683

MarkDWilliams opened this issue Sep 12, 2024 · 3 comments
Assignees

Comments

@MarkDWilliams
Copy link
Collaborator

MarkDWilliams commented Sep 12, 2024

Not for implementation right away (we'll need to wait for the corresponding changes to appraiser which will allow them to accept compressed data), but I've been talking with @maximusunc about this, and I believe this is the plan

  1. Changes will be made to Appraiser to allow it to accept compressed (gzip) data or plain JSON
  2. It will return responses in the same form as it received the request (i.e. If you send a JSON, you'll get a JSON. If you send gzip, you'll get gzip)

This should save us some "over the wire" time and increase performance. On our end, we will need to alter appraise() to compress the data it sends (or perhaps just don't UNcompress the Message/data before we send it over. I'll have to look). I would recommend that we uncompress the data we receive even if we could technically just save it as is to the database with slightly better performance. Saving it directly in zipped form, we wouldn't be able to see if there were any issues. Decompressing and compressing are cheap operations. Better safe than sorry.

@ShervinAbd92
Copy link
Collaborator

I agree with you. overheard Max telling Chris about it this morning and i believe thats good call.

@MarkDWilliams
Copy link
Collaborator Author

MarkDWilliams commented Sep 12, 2024

It came up last night over dinner, thus justifying us staying around for the hackathon. Important work really DOES get done outside the core hours!

@ShervinAbd92
Copy link
Collaborator

i believe this is implemented!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants