You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've been encountering persistent issues with handling of dataset submission errors. The DataPackage collection is a central component of this process, but in the 7+ years since its creation, it's accumulated some issues that may be contributing to the problems we're seeing. Cleaning up the DataPackage will help us improve error handling and make it easier to add unit tests and resource maps validation.
Assessment of DataPackage:
The DataPackage is a Backbone Collection being used like a Model, which complicates tracking and responding to property changes.
Both DataPackage and PackageModel have methods that handle serialization of resource maps.
There's no validation of resource maps before they are serialized and saved. Since Metacat also does not validate resource maps, invalid resource maps can be saved without error, which leads to broken datasets (the "missing files" issue).
Some errors during the save process are not caught or communicated to the user, which results in the endless spinner issue.
The rdflib dependency has not been updated in over 7 years
The DataPackage contains methods that are incomplete or unused (e.g. transferQueue)
We've been encountering persistent issues with handling of dataset submission errors. The
DataPackage
collection is a central component of this process, but in the 7+ years since its creation, it's accumulated some issues that may be contributing to the problems we're seeing. Cleaning up theDataPackage
will help us improve error handling and make it easier to add unit tests and resource maps validation.Assessment of
DataPackage
:DataPackage
is a Backbone Collection being used like a Model, which complicates tracking and responding to property changes.DataPackage
andPackageModel
have methods that handle serialization of resource maps.rdflib
dependency has not been updated in over 7 yearsDataPackage
contains methods that are incomplete or unused (e.g.transferQueue
)DataPackage
was intended to replace the olderPackageModel
, but this transition was never fully completed. Some functionality is still dependent onPackageModel
which is still being used in some places.Where
DataPackage
vsPackageModel
are in use:DataPackage
(to cleanup)EML211EditorView
PackageModel
(to deprecate)SearchResultView
DownloadButtonView
PackageTableView
(deprecated)Both
DataPackage
&PackageModel
DataPackageView
MetadataView
During the cleanup, we will:
DataPackage
as a Model containing a Collection of DataONEObject models (EML/ScienceMetadata, DataObjects, and nested DataPackages)PackageModel
toDataPackage
, deprecatePackageModel
.DataPackage
, at least for the most critical parts.The text was updated successfully, but these errors were encountered: