Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fates sites to be initialized, but inactive, on virtual (i.e. zero-weight) columns #8

Open
glemieux opened this issue Apr 3, 2024 · 0 comments

Comments

@glemieux
Copy link

glemieux commented Apr 3, 2024

If I understand correctly, it is possible for a column's %active status to be dynamically updated during runtime. We currently only initialize fates to run on columns that are active during elm initialization here:

if ( (lun_pp%itype(l) == istsoil) .and. (col_pp%active(c)) ) then
s = s + 1
collist(s) = c
this%f2hmap(nc)%hsites(c) = s
col_pp%is_fates(c) = .true.

In attempting to enable the creation of "virtual" columns that capture a time-since-fire disturbance age value, we will need to make sure that we have fates sites setup on these virtual columns, but inactive. Note that we currently check to make sure that every clump has a fates site and will end the run if it does not here:
if( this%fates(nc)%nsites == 0 ) then
write(iulog,*) 'Clump ',nc,' had no valid FATES sites'
write(iulog,*) 'This will likely cause problems until code is improved'
call endrun(msg=errMsg(sourcefile, __LINE__))
end if

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant