Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updata Tests for file import functions - importing csv files #2

Open
warren-davies4 opened this issue Nov 6, 2024 · 0 comments
Open

Comments

@warren-davies4
Copy link
Collaborator

The tests for the file import functions scan the current directory and pass if they find nothing, because the test assumes there are no csvs or xlsx files in the project folder.

However the tests failed because sometimes packages contain csv files, and if you have one installed, the function will find it in your vanv folder.

This will be updated so that the test only scans the tests/ folder.

However this only tests when it successfully doesn't find a file. We should also add two more tests:

  • test that it correctly finds a csv file
  • test that it correctly finds more than one csvs by looking in subdirectories also
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant