Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataset #10

Closed
slucey opened this issue Apr 23, 2020 · 6 comments · May be fixed by #67
Closed

Add dataset #10

slucey opened this issue Apr 23, 2020 · 6 comments · May be fixed by #67
Assignees
Labels
documentation Enhance documentation for functions enhancement New feature or request
Milestone

Comments

@slucey
Copy link
Member

slucey commented Apr 23, 2020

Include R Ecosystem with package

@slucey slucey added the enhancement New feature or request label Apr 23, 2020
@slucey slucey self-assigned this Sep 13, 2023
@slucey slucey added the documentation Enhance documentation for functions label Sep 13, 2023
@slucey
Copy link
Member Author

slucey commented Sep 13, 2023

Need data set for ecosense vignette as well

@kaydin
Copy link
Collaborator

kaydin commented Sep 13, 2023

Did substantial structuring of "how to add example ecosystems" on the eco_data branch, including documentation and references, for the sense systems. This includes a data-raw folder and Data.R in the R folder. The method of inclusion should be matched/same (merged) for all systems?

@kaydin
Copy link
Collaborator

kaydin commented Sep 14, 2023

@slucey looking more closely at history, I merged eco_data branch into the dev branch back in January, so dev should contain the ecosense ecosystems (compiled into R data files via the Rpath_unbalanaced_data.R script in the data-raw directory). The descriptions/docs are in the data.R script in the R directory. So the todo here is reviewing to making sure all included ecosystems are relatively consistent in inclusion steps. and documentation in data.R? (not sure where anchovy bay etc. are living).

The ecosense vignette itself may need an added step to load the data, I'll check than when reviewing.

@slucey
Copy link
Member Author

slucey commented Sep 14, 2023

@kaydin sounds good. I'll review and make sure the other data sets are in.

@slucey
Copy link
Member Author

slucey commented Sep 27, 2023

Data sets will be merge under pull request #67

@slucey slucey linked a pull request Sep 27, 2023 that will close this issue
@slucey slucey added this to the Version 0.1.5 milestone Sep 27, 2023
@aw2113 aw2113 closed this as completed Mar 13, 2024
@aw2113 aw2113 reopened this Mar 13, 2024
@kaydin kaydin assigned kaydin and unassigned slucey Oct 23, 2024
@kaydin
Copy link
Collaborator

kaydin commented Oct 23, 2024

Completed with dev push

@kaydin kaydin closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Enhance documentation for functions enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants