line in assign_unknown.R causing error in comlandr pull

[sgaichas]

This line causes a mismatch error in a merge for me, because it results in names VAR1 VAR2 etc instead of the intended names.

comlandr/R/assign_unknown.R

Line 103 in 28b4c58

stra.combo <- unlist(stra.combo[, ..num.stra.var])

To correct this, I added unname() to the line:

stra.combo <- unname(unlist(stra.combo[, ..num.stra.var]))

this allowed the function to proceed, so would allowget_comland_data to return the dataset

I have not yet reviewed the dataset but wanted to flag this now

[sgaichas]

Version of R this was running in

> version
               _                           
platform       x86_64-pc-linux-gnu         
arch           x86_64                      
os             linux-gnu                   
system         x86_64, linux-gnu           
status                                     
major          4                           
minor          3.1                         
year           2023                        
month          06                          
day            16                          
svn rev        84548                       
language       R                           
version.string R version 4.3.1 (2023-06-16)
nickname       Beagle Scouts     

[sgaichas]

comlandr call arguments

# my call arguments
filterByYear = 1964:2023
refYear = 2021 
refMonth = 1
aggArea = T
userAreas = epuAreas 
applyPropLand = F # Bug? This mismatches default for value but aggregate_area code sets this to F not value to F
aggGear = F
unkVar = c('MONTH', 'NEGEAR', 'EPU')
knStrata = c('HY', 'QY', 'MONTH', 'NEGEAR', 'TONCL2',
             'EPU')

# other default call arguments
useLanded = T
removeParts = T
useHerringMaine = T
useForeign = T
disagSkatesHakes = T
areaDescription = 'EPU'
propDescription = 'MeanProp'
fleetDescription = 'Fleet'
filterByArea = NA
applyPropValue = T # Bug? This default mismatches entered value but aggregate_area code sets land to F not value

[andybeet]

I dont get this error using the argument values listed above. Not sure why you are getting this error and i am not. We are using different versions of R but i feel like its something else.

sessionInfo()
#> R version 4.2.0 (2022-04-22 ucrt)
#> Platform: x86_64-w64-mingw32/x64 (64-bit)
#> Running under: Windows 10 x64 (build 19045)
#> 
#> Matrix products: default
#> 
#> locale:
#> [1] LC_COLLATE=English_United States.utf8 
#> [2] LC_CTYPE=English_United States.utf8   
#> [3] LC_MONETARY=English_United States.utf8
#> [4] LC_NUMERIC=C                          
#> [5] LC_TIME=English_United States.utf8    
#> 
#> attached base packages:
#> [1] stats     graphics  grDevices utils     datasets  methods   base     
#> 
#> loaded via a namespace (and not attached):
#>  [1] digest_0.6.29     withr_3.0.0       R.methodsS3_1.8.2 lifecycle_1.0.4  
#>  [5] magrittr_2.0.3    reprex_2.1.0      evaluate_0.23     rlang_1.1.3      
#>  [9] cli_3.6.2         rstudioapi_0.16.0 fs_1.6.3          R.utils_2.12.3   
#> [13] R.oo_1.26.0       vctrs_0.6.5       styler_1.10.3     rmarkdown_2.27   
#> [17] tools_4.2.0       R.cache_0.16.0    glue_1.6.2        purrr_1.0.2      
#> [21] xfun_0.42         yaml_2.3.5        fastmap_1.1.1     compiler_4.2.0   
#> [25] htmltools_0.5.8.1 knitr_1.45

^{Created on 2024-10-01 with reprex v2.1.0}