Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculating bias/RMSE with multiple obtypes; x-axis limits when obcount is 0 #69

Open
BenjaminBlake-NOAA opened this issue Sep 22, 2021 · 0 comments

Comments

@BenjaminBlake-NOAA
Copy link

Two proposed fixes for the plot_gsi_stat_exp.py script are listed below:

Calculating the bias/RMSE values in the script only works if you select one obtype. When reading in multiple obtypes, the mean (bias and RMSE) and sum (ob count) calculations are incorrect because the script still calculates the values using one obtype.

If there are no observations in a given vertical layer (the count is 0), then dividing by 0 to get the bias/RMSE will result in NaNs. When there are NaNs in the arrays, the x-axis limits for the bias/RMSE plots don't get set properly. Some code could be added to ignore the NaNs in the min/max calculation for the x-axis limits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant