Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ctest yaml files when building RDASApp #273

Open
SamuelDegelia-NOAA opened this issue Feb 6, 2025 · 0 comments
Open

Create ctest yaml files when building RDASApp #273

SamuelDegelia-NOAA opened this issue Feb 6, 2025 · 0 comments
Assignees

Comments

@SamuelDegelia-NOAA
Copy link
Contributor

Description

The large yaml files used for the ctests in rrfs-test/testinput currently lag behind many of the changes made to individual yamls in rrfs-test/validated_yamls/templates. This means that many recent developments are not included in either our ctests or the experiments set up to run in exp/mpas_2024052700.

It would be better for us to build these large yamls when RDASApp is built by incorporating gen_yaml_ctest.sh into build.sh. This will allow us to better verify any changes made to the component yamls through the context of a passed/failed ctest. Additionally, this will make PRs easier to review if changes do not need to be made to both the component and larger, merged yamls (e.g., my PR #272).

One note here is that anyone who updates a yaml under rrfs-test/validated_yamls/templates will now need to also rerun the ctests and update the associated reference files in rrfs-test/testoutput.

Requirements

Create the yaml files used for ctests when RDASApp is built.

Acceptance Criteria (Definition of Done)

Able to run ctests by building the yaml files on the fly with RDASApp.

Dependencies

None

@SamuelDegelia-NOAA SamuelDegelia-NOAA self-assigned this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant