Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracker archiving has a typo in it #3029

Closed
DavidHuber-NOAA opened this issue Oct 23, 2024 · 1 comment
Closed

Tracker archiving has a typo in it #3029

DavidHuber-NOAA opened this issue Oct 23, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@DavidHuber-NOAA
Copy link
Contributor

What is wrong?

The archiving job is not looking for the correct cyclone tracker files when attempting to rename and archive them.

What should have happened?

The archive.py _rename_cyclone_expt function should look for cyclone files, not cycle files.

What machines are impacted?

All or N/A

What global-workflow hash are you using?

5cc20ec

Steps to reproduce

  1. Run a C48_ATM experiment through the archiving step.
  2. Look for atcfunix files in ${COMROOT}/gfs.20210323/12/products/atmos/cyclone/tracker and/or ${ARCDIR}.

Additional information

Reported by @JiayiPeng-NOAA and @JongilHan66 during HR4 testing.

Do you have a proposed solution?

Change lines

if run == "gfs":
in_track_file = (track_dir_in + "/avno.t" +
cycle_HH + "z.cycle.trackatcfunix")
in_track_p_file = (track_dir_in + "/avnop.t" +
cycle_HH + "z.cycle.trackatcfunixp")
elif run == "gdas":
in_track_file = (track_dir_in + "/gdas.t" +
cycle_HH + "z.cycle.trackatcfunix")
in_track_p_file = (track_dir_in + "/gdasp.t" +
cycle_HH + "z.cycle.trackatcfunixp")

to

        if run == "gfs":
            in_track_file = (track_dir_in + "/avno.t" +
                             cycle_HH + "z.cyclone.trackatcfunix")
            in_track_p_file = (track_dir_in + "/avnop.t" +
                               cycle_HH + "z.cyclone.trackatcfunixp")
        elif run == "gdas":
            in_track_file = (track_dir_in + "/gdas.t" +
                             cycle_HH + "z.cyclone.trackatcfunix")
            in_track_p_file = (track_dir_in + "/gdasp.t" +
                               cycle_HH + "z.cyclone.trackatcfunixp")
@DavidHuber-NOAA DavidHuber-NOAA added bug Something isn't working triage Issues that are triage labels Oct 23, 2024
@DavidHuber-NOAA DavidHuber-NOAA self-assigned this Oct 23, 2024
@DavidHuber-NOAA DavidHuber-NOAA removed the triage Issues that are triage label Oct 23, 2024
DavidHuber-NOAA added a commit to DavidHuber-NOAA/global-workflow that referenced this issue Oct 23, 2024
@DavidHuber-NOAA
Copy link
Contributor Author

Fixed via #3030.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant