Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-small_grib truncates lat/lon/dlat/dlon rather than round #142

Open
webisu opened this issue Jun 24, 2024 · 3 comments
Open

-small_grib truncates lat/lon/dlat/dlon rather than round #142

webisu opened this issue Jun 24, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@webisu
Copy link
Collaborator

webisu commented Jun 24, 2024

When converting lat/lon/dlat/dlon to integer, truncation is used rather than rounding.
Ex. initial grid has a dlat-dlon=0.02 degrees (not exact binary double precision number)
When using -small_grib, the exterme value is xxx.019999 rather than xx.020000

@edwardhartnett
Copy link
Contributor

Can you add a unit test to demonstrate this bug?

@edwardhartnett edwardhartnett added the bug Something isn't working label Jun 29, 2024
@webisu
Copy link
Collaborator Author

webisu commented Jul 1, 2024 via email

@edwardhartnett
Copy link
Contributor

I mean put up a PR with a test that demonstrates this problem. That is, a test which fails, but would pass if this were fixed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants