Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions failing #15

Open
k-doering-NOAA opened this issue Oct 5, 2022 · 4 comments
Open

Github actions failing #15

k-doering-NOAA opened this issue Oct 5, 2022 · 4 comments

Comments

@k-doering-NOAA
Copy link
Member

The r cmd check github actions are failing:
https://github.com/nmfs-fish-tools/r4MAS/actions/runs/3183901298/jobs/5191673619#step:8:269

@ChristineStawitz-NOAA , are you the right person to tag for this? Or should it be @Bai-Li-NOAA or @msupernaw ?

@ChristineStawitz-NOAA
Copy link
Collaborator

Hm I looked at the log and this is happening because it is failing the testthat tests. I'm not sure if this is due to a problem in the tests themselves or the code so I think we should go to Bai first to confirm there is not a problem with the tests and then Matthew if its something wrong with the MAS model itself

@k-doering-NOAA
Copy link
Member Author

Ok - I also saw some of the MAS test were failing (from this dashboard: https://github.com/nmfs-fish-tools/status) so I'm not sure if that is related...

@Bai-Li-NOAA
Copy link
Contributor

@k-doering-NOAA and @ChristineStawitz-NOAA , I will take a close look at the failed tests and see if I need to pass it to Matthew.

@Bai-Li-NOAA
Copy link
Contributor

The R tests pass on my Windows laptop, however, running the tests through r-cmd-check failed on Windows and MacOS. The error logs can be found in the artifacts section here. @msupernaw, could you run the R tests on your laptop?

Also, r4MAS cannot be compiled on Linux (see error log here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants