Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add allocation check to astronomy_end #1368

Open
rem1776 opened this issue Sep 15, 2023 · 0 comments
Open

add allocation check to astronomy_end #1368

rem1776 opened this issue Sep 15, 2023 · 0 comments
Assignees

Comments

@rem1776
Copy link
Contributor

rem1776 commented Sep 15, 2023

Describe the bug
In astronomy_end there is no allocation check before the deallocation of module variables:

FMS/astronomy/astronomy.F90

Lines 1977 to 1985 in 61cc3b9

!----------------------------------------------------------------------
!> deallocate module variables.
!----------------------------------------------------------------------
deallocate (orb_angle)
if (allocated(cosz_ann) ) then
deallocate (cosz_ann)
deallocate (fracday_ann)
deallocate (solar_ann)
endif

To Reproduce
n/a

Expected behavior
checks should be added for the deallocations

System Environment
n/a

Additional context
came up during mixed precision updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants