Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactorization: subroutine coupler_chksum removal #115

Open
mlee03 opened this issue May 18, 2024 · 0 comments
Open

refactorization: subroutine coupler_chksum removal #115

mlee03 opened this issue May 18, 2024 · 0 comments

Comments

@mlee03
Copy link
Contributor

mlee03 commented May 18, 2024

This issue proposes to remove the subroutine coupler_chksum. In full coupler_main, the subroutine coupler_chksum is called before or at the end of the grouped calls to atmos_ice_land_chksum and ocean_chkum. In coupler_chksum, the checksums of tracers and the below select fields are computed twice and are written to stdout twice back to back.

Atm%t_box
Atm%z_bot
Atm%p_bot
Atm%u_bot
Atm%v_bot
Atm%p_urf
Atm%gust
Land%t_surf
Land%t_ca
Land%rough_mom
Land%rough_heat
Land%rough_scale
Ice%t_surf
Ice%rough_mom
Ice%rough_heat
Ice%rough_moist
Ice%ocean_fields

Unless it is useful to group the checksums of the above fields in stdout (for example, for easier analysis) coupler_chksum should be removed to avoid unnecessary redundancy.

@mlee03 mlee03 changed the title refactorization: coupler_chksum cleanup refactorization: subroutine coupler_chksum removal May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant