Simple coupler missing argument to diag_manager_init that results in missing prepended date in associated_files attribute

[ceblanton]

Users of the simple coupler (e.g. aquaplanet) find that their history files are missing a prepended date in the associated_files attribute.

For example, this is a typical associated_files global attribute:
:associated_files = "land_area: 20980101.land_static.nc" ;

If one uses the simple coupler, they get this instead:
:associated_files = "land_area: land_static.nc" ;

The result is that fregrid fails to find the expected associated file (that has the prepended date) and post-processing fails.

While poking in dev/master with @menzel-gfdl, we found that the diag_manager_init expects a certain argument to activate the date-prepending behavior. The full coupler passes this in but the simple coupler does not. It also prints a distinctive error message as it fails to use the prepended date.

The full coupler (https://github.com/NOAA-GFDL/coupler/blob/dev/master/full/coupler_main.F90 line 1638) has:
call diag_manager_init(DIAG_MODEL_SUBSET=diag_model_subset, TIME_INIT=date)

The TIME_INIT argument is the one that simple_coupler needs in order for the date-prepending code to be activated.

[thomas-robinson]

I can attempt to fix this. It looks like date is set the same way in the full and simple coupler. I will try passing the date into diag_manager_init to see if that fixes the problem.

[thomas-robinson]

@ceblanton do you remember who was having this issue?

[ceblanton]

Levi's aquaplanet simulations

[thomas-robinson]

@ceblanton do you remember specifically which experiment? I need a test case.

[ceblanton]

I think any in the aquaplanet XML- one was c96L33_am4p0_aqua_prectl_e