Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge issues with hord=6 #269

Open
wmputman opened this issue May 3, 2023 · 1 comment
Open

Edge issues with hord=6 #269

wmputman opened this issue May 3, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@wmputman
Copy link

wmputman commented May 3, 2023

Is your feature request related to a problem? Please describe.
When using hord=6 schemes there is a clear and detrimental edge problem with artificial convergence producing unwanted edge precipitation

Describe the solution you'd like
There is a simple code addition to alleviate this problem.

For xtp / xppm:

!WMP
! fix edge issues
if ( (.not.nested) .and. grid_type < 3) then
if( is==1 ) then
smt5(0) = bl(0)*br(0) < 0.
smt5(1) = bl(1)*br(1) < 0.
endif
if( (ie+1)==npx ) then
smt5(npx-1) = bl(npx-1)*br(npx-1) < 0.
smt5(npx ) = bl(npx )*br(npx ) < 0.
endif
endif
!WMP

and for ytp / yppm:

!WMP
! fix edge issues
if ( (.not.nested) .and. grid_type < 3) then
if( is==1 ) then
smt5(0) = bl(0)*br(0) < 0.
smt5(1) = bl(1)*br(1) < 0.
endif
if( (ie+1)==npx ) then
smt5(npx-1) = bl(npx-1)*br(npx-1) < 0.
smt5(npx ) = bl(npx )*br(npx ) < 0.
endif
endif
!WMP

See PPT slides attached.
Putman-FV3-Edge.pptx

@wmputman wmputman added the enhancement New feature or request label May 3, 2023
@lharris4
Copy link
Contributor

lharris4 commented Jun 9, 2023

Hi, Bill. Just getting back to this. Could you point to the place in your codes where this is to be added or removed?

Thanks,
Lucas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants