Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/emc: follow-up changes for PR #330 #345

Open
climbfuji opened this issue Jun 27, 2024 · 3 comments
Open

dev/emc: follow-up changes for PR #330 #345

climbfuji opened this issue Jun 27, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@climbfuji
Copy link

Is your feature request related to a problem? Please describe.

During the review process of #330, the following items were noted as follow-up work:

Describe the solution you'd like

See above

Describe alternatives you've considered

Leave things as is - not a good idea, since we will be missing out on expected performance improvements

Additional context

n/a

@bensonr
Copy link
Contributor

bensonr commented Aug 8, 2024

@climbfuji - did this get addressed in #330 or is it a follow on issue to be addressed?

@climbfuji
Copy link
Author

No, this is indeed follow-up work that will hopefully lead to less code and small performance gains. Hopefully someone from EMC can pick this up.

@bensonr
Copy link
Contributor

bensonr commented Aug 8, 2024

Thanks, we will leave this open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants