Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Units for fhcyc in inline comment incorrect? #27

Open
StevePny opened this issue Sep 25, 2023 · 0 comments
Open

Units for fhcyc in inline comment incorrect? #27

StevePny opened this issue Sep 25, 2023 · 0 comments

Comments

@StevePny
Copy link

StevePny commented Sep 25, 2023 •
edited
Loading

SHiELD_physics/GFS_layer/GFS_typedefs.F90

Line 463 in 0ff11e8

real(kind=kind_phys) :: fhcyc !< frequency for surface data cycling (secs)

There is a comment here that indicates that fhcyc has units of 'seconds', however below in the same file it multiplies by 3600., indicating that the implied units is 'hours'. I also see in the regional_Laura test case that this is supplied as '24.', which I assume intends a daily update.

SHiELD_physics/GFS_layer/GFS_typedefs.F90

Line 2535 in 0ff11e8

Model%nscyc = nint(fhcyc*3600./Model%dtp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StevePny