Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fre make container build needs exec script in second stage #371

Open
thomas-robinson opened this issue Feb 26, 2025 · 0 comments
Open

fre make container build needs exec script in second stage #371

thomas-robinson opened this issue Feb 26, 2025 · 0 comments
Assignees

Comments

@thomas-robinson
Copy link
Member

thomas-robinson commented Feb 26, 2025

Describe the bug
The two stage container build in fre make needs to copy over the execution script from the first stage and set up a symbolic link in the second stage. Here is an example of what the Dockerfile should look like for ESM

COPY --from=builder /apps/esm4.5_om5b08_compile_v6_cobv3_mekep/exec /apps/esm4.5_om5b08_compile_v6_cobv3_mekep/exec
RUN mkdir -p /apps/bin \
 && ln -sf /apps/esm4.5_om5b08_compile_v6_cobv3_mekep/exec/execrunscript.sh /apps/bin/execrunscript.sh

This can be done by modifying fre make to add in the link set up line in the second stage of the Dockerfile.

Additionally, the LD_LIBRARY_PATH of the container is being overwritten in frerun. frerun needs to be patched to allow for the LD_LIBRARY_PATH of the container to be appended on to the end of the APPTAINER_LD_LIBRARY_PATH. It's currently set up like this:
setenv APPTAINERENV_LD_LIBRARY_PATH "${CRAY_LD_LIBRARY_PATH}:${LD_LIBRARY_PATH}:/opt/cray/pe/lib64:/usr/lib64/libibverbs:/opt/cray/libfabric/1.20.1/lib64:/opt/cray/pals/1.4/lib"
It needs to have no quotes " and have :\$LD_LIBRARY_PATH added to the end. Final should be:
setenv APPTAINERENV_LD_LIBRARY_PATH ${CRAY_LD_LIBRARY_PATH}:${LD_LIBRARY_PATH}:/opt/cray/pe/lib64:/usr/lib64/libibverbs:/opt/cray/libfabric/1.20.1/lib64:/opt/cray/pals/1.4/lib:\$LD_LIBRARY_PATH @rem1776

To Reproduce

Expected behavior
The model running

Additional context
Tom will do fre make. Ryan may need to do frerun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant