Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I would like to be able to include custom time_pools with event detection #406

Open
HankHerr-NOAA opened this issue Feb 6, 2025 · 0 comments
Labels
enhancement New feature or improvement

Comments

@HankHerr-NOAA
Copy link
Contributor

This is to satisfy the potential requirement of ensuring the events include historic events of significance that event detection could overlook. Per James in #382:

For example, let's say that event detection fails to identify a historically important event and a user wants to add it in alongside the detected events. Sure, that indicates a limitation with event detection, but I guess a user should be able to mitigate this. Assuming it isn't additional work, I lean towards demoting this to a warning rather than an error. I don't think it makes sense to allow in combination with a regular sequence of valid_date_pools, however, and this should produce an error.

The exception that occurs when including time_pools with event_detection is this:

Caused by: wres.config.yaml.DeclarationException: Encountered 1 error(s) in the declared evaluation, which must be fixed:
    - Event detection was declared alongside explicit time pools, which is not allowed because event detection also generates time pools. Please remove the declaration of either 'event_detection' or 'time_pools' and try again.

The declaration I was using to test this capability was .../wresTestData/github382/single_valued_ahps_declaration.value_restricted.time_pools.yml. I don't think its necessary for me to share it to implement the feature, but I'm providing it here so that I can reuse it later to UAT the feature. All I did was take the declaration in #404 and define a multi year time pool in the middle of the overall reference_dates.

Thanks,

Hank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

1 participant