You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is to satisfy the potential requirement of ensuring the events include historic events of significance that event detection could overlook. Per James in #382:
For example, let's say that event detection fails to identify a historically important event and a user wants to add it in alongside the detected events. Sure, that indicates a limitation with event detection, but I guess a user should be able to mitigate this. Assuming it isn't additional work, I lean towards demoting this to a warning rather than an error. I don't think it makes sense to allow in combination with a regular sequence of valid_date_pools, however, and this should produce an error.
The exception that occurs when including time_pools with event_detection is this:
Caused by: wres.config.yaml.DeclarationException: Encountered 1 error(s) in the declared evaluation, which must be fixed:
- Event detection was declared alongside explicit time pools, which is not allowed because event detection also generates time pools. Please remove the declaration of either 'event_detection' or 'time_pools' and try again.
The declaration I was using to test this capability was .../wresTestData/github382/single_valued_ahps_declaration.value_restricted.time_pools.yml. I don't think its necessary for me to share it to implement the feature, but I'm providing it here so that I can reuse it later to UAT the feature. All I did was take the declaration in #404 and define a multi year time pool in the middle of the overall reference_dates.
Thanks,
Hank
The text was updated successfully, but these errors were encountered:
This is to satisfy the potential requirement of ensuring the events include historic events of significance that event detection could overlook. Per James in #382:
The exception that occurs when including
time_pools
withevent_detection
is this:The declaration I was using to test this capability was
.../wresTestData/github382/single_valued_ahps_declaration.value_restricted.time_pools.yml
. I don't think its necessary for me to share it to implement the feature, but I'm providing it here so that I can reuse it later to UAT the feature. All I did was take the declaration in #404 and define a multi year time pool in the middle of the overallreference_dates
.Thanks,
Hank
The text was updated successfully, but these errors were encountered: