Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor testing #90

Open
jd-lara opened this issue Feb 5, 2025 · 1 comment
Open

Refactor testing #90

jd-lara opened this issue Feb 5, 2025 · 1 comment
Assignees
@rbolgaryn

Comments

@jd-lara
Copy link
Member

jd-lara commented Feb 5, 2025

We are keeping in the test code an old and inefficient implementation of NR with matrices as benchmark. This methodology means we need to maintain essentially 2 code bases for NR. We need to refactor this testing method and remove duplicate code.
@jd-lara jd-lara mentioned this issue Feb 5, 2025
Merged
@jd-lara jd-lara changed the title Refactor testing of NR implementation Refactor testing Feb 5, 2025
@jd-lara
Copy link
Member Author

jd-lara commented Feb 5, 2025

also do this #53 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rbolgaryn rbolgaryn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jd-lara @rbolgaryn