Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a warning for unused actuators #10944

Open
Myoldmopar opened this issue Feb 18, 2025 · 0 comments
Open

Provide a warning for unused actuators #10944

Myoldmopar opened this issue Feb 18, 2025 · 0 comments
Labels
NewFeatureRequest This "issue" is a new feature request, not a defect report Triage Issue needs to be assessed and labeled, further information on reported might be needed

Comments

@Myoldmopar
Copy link
Member

Myoldmopar commented Feb 18, 2025

General Summary

I debugged a file for quite a while due to weird behavior, only to have the error be a typo in an EMS program.

Detailed Description

There was an actuator named A1. Inside the program there was a SET Al = 2. But because of the typo, the Al variable was just a local variable that was never used. And the actuator was never assigned.

Possible Implementation

A simple flag on each actuator declared in the IDF to check if it was ever assigned seems sufficient. Then at the end of the simulation, a warning could be emitted for any never-assigned actuators.

As an aside, if this was done in Python, then the typo would have caused a failure when looking up the actuator handle, so this is moot there. It may not be worth adding this as we want to nudge people toward the Python side, but it would still be a light lift.

@Myoldmopar Myoldmopar added NewFeatureRequest This "issue" is a new feature request, not a defect report Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeatureRequest This "issue" is a new feature request, not a defect report Triage Issue needs to be assessed and labeled, further information on reported might be needed
Projects
None yet
Development

No branches or pull requests

1 participant