Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow instantaneous water heaters w/ larger tank volumes #1858

Open
shorowit opened this issue Oct 15, 2024 · 2 comments · May be fixed by #1860
Open

Allow instantaneous water heaters w/ larger tank volumes #1858

shorowit opened this issue Oct 15, 2024 · 2 comments · May be fixed by #1860
Assignees
Labels
enhancement New feature or request priority medium

Comments

@shorowit
Copy link
Contributor

shorowit commented Oct 15, 2024

For example, this product is called an instantaneous water heater but it has a 34 gal tank:

Presumably it's considered instantaneous because of the large burner rate.

We previously assumed that instantaneous water heaters have tank volumes <= 2 gal and thus insignificant standby losses. To handle products like this, we should allow tank volume as an input and, if it's greater than 2 gal, model it as a conventional storage water heater.

@shorowit shorowit added the enhancement New feature or request label Oct 15, 2024
@shorowit
Copy link
Contributor Author

We should also allow HeatingCapacity for instantaneous water heaters.

@shorowit
Copy link
Contributor Author

And we should probably replace "tankless" with "instantaneous" in our code.

@shorowit shorowit self-assigned this Oct 15, 2024
@shorowit shorowit linked a pull request Oct 16, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority medium
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

1 participant