Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RapidJSON GenericDocument in place of Document for UTF16 encoding #1864

Open
cpaulgilman opened this issue Oct 4, 2024 · 0 comments
Open

Use RapidJSON GenericDocument in place of Document for UTF16 encoding #1864

cpaulgilman opened this issue Oct 4, 2024 · 0 comments
Assignees
@cpaulgilman
Labels
bug
Milestone
SAM Fall 2024 Rel...

Comments

@cpaulgilman
Copy link
Collaborator

In some cases, RapidJSON fails to read JSON because of encoding.

To fix a problem with this for URDB downloads, we changed rapidjson::Document reader; to rapidjson::GenericDocument < rapidjson::UTF16<> > reader;. We should make this change for all of SAM and WEX.

See #1862.

This should be tested in Windows, Mac, and Linux.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpaulgilman cpaulgilman

Labels
bug
Projects
None yet
Milestone
SAM Fall 2024 Release
Development

No branches or pull requests
1 participant
@cpaulgilman