Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"net" columns are empty in ResStock timeseries #446

Closed
rajeee opened this issue Apr 1, 2024 · 2 comments
Closed

"net" columns are empty in ResStock timeseries #446

rajeee opened this issue Apr 1, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@rajeee
Copy link
Contributor

rajeee commented Apr 1, 2024

Describe the bug
Buildings that don't have PV will not have PV and "net" output columns in the timeseries. This can lead to errors downstream when sum or other aggregations are calculated since the empty columns are interpreted as zero. Interpretation of 0 is correct for the PV energy consumption columns but will be incorrect for the "net" columns such as "fuel_use__electricity__net__kwh", "energy_use__net__kbtu" etc.

To Reproduce
Look at any existing ResStock run.

Expected behavior
The concatenated timeseries files uplaod to s3 will have a correct "net" column values even if the raw timeseries csv from the simulation doesn't.

Additional context
This is causing problem for the EUSS processing.

@rajeee rajeee added the bug Something isn't working label Apr 1, 2024
@rajeee rajeee changed the title "net" columns are empty in timeseries "net" columns are empty in ResStock timeseries Apr 1, 2024
@shorowit
Copy link
Contributor

shorowit commented Apr 4, 2024

I think we can make this change in OS-HPXML. NREL/OpenStudio-HPXML#1676

@rajeee
Copy link
Contributor Author

rajeee commented Apr 17, 2024

Change made in OS-HPXML.

@rajeee rajeee closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants