Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align traces #12

Open
johnpaustian opened this issue Sep 8, 2020 · 3 comments
Open

Align traces #12

johnpaustian opened this issue Sep 8, 2020 · 3 comments

Comments

@johnpaustian
Copy link

johnpaustian commented Sep 8, 2020

Align traces results in an incorrect upward trace shift. I noted your comment that this may occur if the maximum amplitudes are not in the air wave. Do you have a solution for this, possibly a different processing method? See before and after below.

Before
align_traces_before

After
align_traces_after

@dylanmikesell
Copy link

Would a windowed correlation around the direct wave do the trick?

Example in MATLAB here (without windowing): https://www.mathworks.com/help/signal/ug/align-signals-with-different-start-times.html
The underlying tool is crosscorrelation: https://www.mathworks.com/help/signal/ug/align-signals-using-cross-correlation.html

@AlainPlattner
Copy link
Member

That's a great idea!
In the past I have just not used the alignment tool if there was a problem, but it would be great if someone could implement the alignment based on cross-correlation in gprpy! I bet there is a similar very easy to use tool in python. Thanks for the idea Dylan!

@dylanmikesell
Copy link

@AlainPlattner, do you have time to try this out (https://github.com/pearsonkyle/Signal-Alignment) or should John and I try to do it? or here: https://stackoverflow.com/questions/4688715/find-time-shift-between-two-similar-waveforms

I think windowing is important and letting the user select the maximum time (e.g. 10 us in the plot John posted) used in the window with some kind of GUI button/dialogue box. I have no experience with that part in Python so curious if this is something that you could implement more quickly than John or I.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants