Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not an Issue Just a Question #16

Open
bflinchum opened this issue Feb 26, 2021 · 1 comment
Open

Not an Issue Just a Question #16

bflinchum opened this issue Feb 26, 2021 · 1 comment

Comments

@bflinchum
Copy link

Is this still an active project? I am new to git Hub and not sure how to contribute and track changes to code through git but I love this program. It's amazing for teaching!

This package would be so perfect for my uses if we could add a Band-pass filter and an wave-number filter.

I have downloaded and looked at the code. I could probably easily write these two filters but would have no idea how to add it to the GUI. I have always used python for scripting not GUI development.

Is this something that we could add to a new version?

Thanks,
Brady
[email protected]

@AlainPlattner
Copy link
Member

Hi Brady,

I apologize that it took me so long to respond. Yes, I keep updating GPRPy and new additions are always welcome.

The filters that I had implemented are very simple and work via averaging pixels. I personally am a huge fan of simplicity when it comes to GPR data processing and find working with pixel averages simpler (and potentially more stable) than spectral (Fourier) transformations. I personally try to use minimal processing for my data and really only use it to make things that are already visible in the raw data easier to interpret.

GPRPy currently has a high-pass filter along each trace via "dewow", where a running mean of a chosen number of pixels is subtracted from each pixel. A low-pass filter along each trace is implemented via "smooth (temp)", where each pixel is replaced by a running mean of a chosen window width. So you can do band-pass filtering by applying both a dewow and a smooth (temp) filter. For the window width you can calculate how many pixels a chosen wavelength has based on the sampling rate of your data.

If you think that a spectral version would be a worthwhile improvement you can fork the repository and start building it into your own version of GPRPy. I am happy to help you with it if needed.

Hope this helps. Also, please feel free to reach out via my work email: [email protected]

Best,
Alain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants