-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use autogenerated python apis for regobs, warning apis, etc #6
Comments
If we think it is a good idea to use the auto-generated packages, they should be updated before we start using them. |
Those python libraries will still basically return JSONs for single days, right? So while it might be a good idea, it won't allow us to remove any code från varsomdata, except some HTTP requests. Or have I misunderstood what those libraries do? |
If you look at Compare this class: varsomdata/varsomdata/getobservations.py Line 1145 in 5c7b750
To this autogenerated class: and you can see the autogenerated code is pretty similar. By using the autogenerated code we could probably remove most of the code from |
We would have less control over how the mapping is done, so I am not saying it's the best solution, but we could probably remove a lot of code I think, and changes in the API would be easy to implement, mostly just autogenerating the api/models code again. |
I did an experiment some time ago to auto-generate python apis using swagger:
They can be generated using asyncio or without.
We should consider using these in varsomdata.
I am not sure if it is a good idea or not, but we should discuss it here.
The text was updated successfully, but these errors were encountered: