Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added content for storage, datasets and containers #65

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Conversation

RobJY
Copy link
Contributor

@RobJY RobJY commented Feb 26, 2025

Getting close to being ready to merge. Making this draft PR to test against lint.

@RobJY RobJY self-assigned this Feb 26, 2025
Copy link

github-actions bot commented Feb 26, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://NYU-ITS.github.io/rts-docs-dev/pr-preview/pr-65/

Built to branch gh-pages at 2025-02-26 23:41 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@RobJY
Copy link
Contributor Author

RobJY commented Feb 26, 2025

I'm getting errors around the iframes I just added:

docs/hpc/07_containers/02_containers.md
  1:1  error  TypeError: Cannot read properties of undefined (reading 'mdxJsxTagStack')
    at Object.enterMdxJsxTag (file:///home/runner/work/rts-docs-dev/rts-docs-dev/node_modules/mdast-util-mdx-jsx/lib/index.js:161:20)
    at compile (file:///usr/local/lib/node_modules/remark-cli/node_modules/mdast-util-from-markdown/lib/index.js:352:40)
    at fromMarkdown (file:///usr/local/lib/node_modules/remark-cli/node_modules/mdast-util-from-markdown/lib/index.js:187:29)
    at parser (file:///usr/local/lib/node_modules/remark-cli/node_modules/remark-parse/lib/index.js:18:12)
    at Function.parse (file:///usr/local/lib/node_modules/remark-cli/node_modules/unified/lib/index.js:273:12)
    at parse (file:///usr/local/lib/node_modules/remark-cli/node_modules/unified-engine/lib/file-pipeline/parse.js:50:36)
    at wrapped (file:///usr/local/lib/node_modules/remark-cli/node_modules/trough/lib/index.js:160:27)
    at next (file:///usr/local/lib/node_modules/remark-cli/node_modules/trough/lib/index.js:86:23)
    at done (file:///usr/local/lib/node_modules/remark-cli/node_modules/trough/lib/index.js:194:7)
    at file:///usr/local/lib/node_modules/remark-cli/node_modules/unified-engine/lib/file-pipeline/read.js:39:7

I'm also getting one for docs/hpc/03_storage/06_data_management.md

any idea how I fix these? Seems like the iframe code is the same as elsewhere in the document, so I'm confused.

@s-sajid-ali
Copy link
Collaborator

s-sajid-ali commented Feb 26, 2025

I'm getting errors around the iframes I just added:

Can you rename them to .mdx ? (https://mdxjs.com/)

Additional context: https://docusaurus.io/docs/markdown-features#mdx-vs-commonmark

@RobJY RobJY requested a review from s-sajid-ali February 26, 2025 23:43
@RobJY RobJY marked this pull request as ready for review February 26, 2025 23:44
@RobJY
Copy link
Contributor Author

RobJY commented Feb 26, 2025

Ok, I think it's ready for review. Please let me know if there's anything I missed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants