Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound effects should use the same audio format as TTS #262

Closed
aaronchantrill opened this issue Apr 26, 2020 · 5 comments
Closed

Sound effects should use the same audio format as TTS #262

aaronchantrill opened this issue Apr 26, 2020 · 5 comments
Labels
Good First Issue! Hacktoberfest Small or non-core issues that could be worked on by Hacktoberfest participants Priority: Low Status: Available Type: Maintenance

Comments

@aaronchantrill
Copy link
Contributor

Detailed Description

Flite produces audio output that is formatted as mono 16 bit little endian at 16MHz, and this appears to be the format generally preferred for both generating and recording audio. The beep_hi.wav and beep_lo.wav files which are used for testing the audio system and providing signals to the user are recorded in 16 bit little endian format, but at 44.1MHz stereo rather than 16MHz mono.

Context

The beep_lo.wav file is played to test whether the user's audio system appears to be set up correctly. The fact that this is playing at a different rate than virtually any other audio file Naomi plays means that it is possible for this test to succeed, but then for Naomi's output to fail.

Possible Implementation

We could just load the current files into audacity, reduce the channels to 1 and change the frequency to 16MHz. We may also want to generate some custom tones. I don't know where these sound effects came from, but they sound uncomfortably close to those used by some other assistants to me.

Your Environment

  • Version used: naomi-dev
  • Environment name and version (e.g. PHP 5.4 on nginx 1.9.1): Python 3.7.3
  • Server type and version: Raspberry Pi 4B
  • Operating System and version: Raspbian Buster
@aaronchantrill aaronchantrill added the Hacktoberfest Small or non-core issues that could be worked on by Hacktoberfest participants label Aug 30, 2020
@sank8-2
Copy link
Contributor

sank8-2 commented Oct 16, 2024

Hi I have changed the audio files to mono and frequency to 16MHz, but I still didn't get the second part. Shall I raise a PR for the audio files?

@aaronchantrill
Copy link
Contributor Author

@sank8-2 please do issue a pull request. I'm not sure what second part you are referring to, but getting a pull request with those files in the correct format would be a big help. Sorry it's taken me so long to get back to you.

@sank8-2
Copy link
Contributor

sank8-2 commented Oct 20, 2024

@aaronchantrill Second part I was referring to generation of custom tones.
Alright I'll raise a PR

@aaronchantrill
Copy link
Contributor Author

Yes, generating custom tones isn't anything I would expect someone new to the project to do, but standardizing the audio out on 16000Hz 1channel 16bit will help.

@aaronchantrill
Copy link
Contributor Author

Merged #428 - Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue! Hacktoberfest Small or non-core issues that could be worked on by Hacktoberfest participants Priority: Low Status: Available Type: Maintenance
Projects
None yet
Development

No branches or pull requests

2 participants