From 70ff02eb3d1de0932c0d03857e7f1fc6cdf20353 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Siiri=20Yl=C3=B6nen?= Date: Thu, 23 Jan 2025 09:49:54 +0200 Subject: [PATCH 1/8] Item titles as title elements, tabindexes and an element at the end of table for sr. --- .../RecordDriver/DefaultRecord/account-entry.phtml | 7 +++---- themes/finna2/templates/checkouts/history.phtml | 4 +++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/themes/finna2/templates/RecordDriver/DefaultRecord/account-entry.phtml b/themes/finna2/templates/RecordDriver/DefaultRecord/account-entry.phtml index 5afba3cb34e..720715b3009 100644 --- a/themes/finna2/templates/RecordDriver/DefaultRecord/account-entry.phtml +++ b/themes/finna2/templates/RecordDriver/DefaultRecord/account-entry.phtml @@ -9,14 +9,13 @@ $title = $driver->getTitle(); $title = empty($title) ? $this->transEsc('Title not available') : $this->escapeHtml($title); } - echo '' . $title . ''; + echo '

' . $title . '

'; } elseif (isset($ilsDetails['title']) && !empty($ilsDetails['title'])) { // If the record is not available in Solr, perhaps the ILS driver sent us a title we can show... - echo '' . $this->escapeHtml($ilsDetails['title']) . ''; + echo '

' . $this->escapeHtml($ilsDetails['title']) . '

'; } else { // Last resort -- indicate that no title could be found. - echo '' . $this->transEsc('Title not available') . ''; + echo '

' . $this->transEsc('Title not available') . '

'; } ?>
diff --git a/themes/finna2/templates/checkouts/history.phtml b/themes/finna2/templates/checkouts/history.phtml index 6defa560ed1..48d7d112dff 100644 --- a/themes/finna2/templates/checkouts/history.phtml +++ b/themes/finna2/templates/checkouts/history.phtml @@ -154,7 +154,7 @@ record($resource)->renderTemplate('account-entry.phtml')?> - + transEscWithPrefix('location_', $ilsDetails['institution_name'])?>
@@ -195,6 +195,8 @@
+ +
transEsc('Loan History')?> transEsc('päättyy')?>
From b8bf16bd507194b07e4eb0b893fb4a83f2ee271c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Siiri=20Yl=C3=B6nen?= Date: Mon, 27 Jan 2025 14:04:47 +0200 Subject: [PATCH 2/8] Tabindexes to headers and skip link to target the page header instead of menu header. --- local/languages/finna/en-gb.ini | 1 + local/languages/finna/fi.ini | 1 + local/languages/finna/sv.ini | 1 + themes/finna2/templates/checkouts/history.phtml | 6 +++--- themes/finna2/templates/holds/list.phtml | 6 ++++-- themes/finna2/templates/layout/layout.phtml | 4 +++- themes/finna2/templates/myresearch/checkedout.phtml | 6 ++++-- themes/finna2/templates/myresearch/illrequests.phtml | 6 ++++-- .../templates/myresearch/storageretrievalrequests.phtml | 6 ++++-- 9 files changed, 25 insertions(+), 12 deletions(-) diff --git a/local/languages/finna/en-gb.ini b/local/languages/finna/en-gb.ini index 5739f75ac11..5f899b233e3 100644 --- a/local/languages/finna/en-gb.ini +++ b/local/languages/finna/en-gb.ini @@ -325,6 +325,7 @@ embedded_content_heading = "Content Cannot be Displayed" embedded_content_description = "This content is displayed from %%serviceBaseUrl%%. To see the content, switch over to the external site or modify your cookie settings and allow the following categories: %%consentCategories%%." embedded_content_external_link = "See content on external site" Empty Book Bag = "Empty basket" +End of List = "End of list" Ensembles = "Ensembles" Established = "Established" event_date_end = "End date" diff --git a/local/languages/finna/fi.ini b/local/languages/finna/fi.ini index c822374d184..37852adf424 100644 --- a/local/languages/finna/fi.ini +++ b/local/languages/finna/fi.ini @@ -317,6 +317,7 @@ embedded_content_heading = "Sisältöä ei voida näyttää" embedded_content_description = "Tämä sisältö haetaan osoitteesta %%serviceBaseUrl%%. Sen näyttämiseen vaaditaan, että hyväksyt sivuston evästeet. Pääset näkemään sisällön joko siirtymällä ulkoiselle sivustolle tai sallimalla evästeasetuksista seuraavat: %%consentCategories%%." embedded_content_external_link = "Siirry ulkoiselle sivustolle" Empty Book Bag = "Tyhjennä" +End of List = "Luettelon loppu" Ensembles = "Kokoonpanot" Era = "Aiheen aika" Established = "Perustettu" diff --git a/local/languages/finna/sv.ini b/local/languages/finna/sv.ini index c8a9aea28d2..9e11d865088 100644 --- a/local/languages/finna/sv.ini +++ b/local/languages/finna/sv.ini @@ -316,6 +316,7 @@ embedded_content_heading = "Innehåll kan inte visas" embedded_content_description = "Innehåll visas från %%serviceBaseUrl%%. För att se innehållet, flytta dig till den externa webbplatsen eller kontrollera dina kakinställningar och acceptera följande kategorier: %%consentCategories%%." embedded_content_external_link = "Se innehållet på den externa webbplatsen" Empty Book Bag = "Tömma" +End of List = "Slutet av listan" Ensembles = "Ensembler" Established = "Grundad" event_date_end = "Slutdatum" diff --git a/themes/finna2/templates/checkouts/history.phtml b/themes/finna2/templates/checkouts/history.phtml index 48d7d112dff..07f1e724adc 100644 --- a/themes/finna2/templates/checkouts/history.phtml +++ b/themes/finna2/templates/checkouts/history.phtml @@ -2,6 +2,7 @@ headTitle($this->translate('Loan History')); + $this->layout()->finnaUseraccountHeader = 'useraccount-content-header'; // Set up breadcrumbs: $this->layout()->breadcrumbs = '
  • ' . $this->transEsc('Your Account') . '
  • ' . $this->transEsc('Loan History') . '
    • '; @@ -25,7 +26,7 @@
    context($this)->renderInContext('librarycards/selectcard.phtml', ['user' => $user, 'label' => 'Library Card'])?>
    -
    +

    transEsc('Loan History')?> ()

    noSupport)): ?> @@ -183,6 +184,7 @@ +

    transEsc('End of List')?>

    @@ -195,8 +197,6 @@
    - -
    transEsc('Loan History')?> transEsc('päättyy')?>
    diff --git a/themes/finna2/templates/holds/list.phtml b/themes/finna2/templates/holds/list.phtml index 00f05b1aef4..95e6210c718 100755 --- a/themes/finna2/templates/holds/list.phtml +++ b/themes/finna2/templates/holds/list.phtml @@ -2,6 +2,7 @@ headTitle($this->translate('My Holds')); + $this->layout()->finnaUseraccountHeader = 'useraccount-content-header'; // Set up breadcrumbs: $this->layout()->breadcrumbs = '
  • ' . $this->transEsc('Your Account') . '
  • ' . $this->transEsc('My Holds') . '
    • '; $user = $this->auth()->getUserObject(); @@ -20,7 +21,7 @@
    context($this)->renderInContext('librarycards/selectcard.phtml', ['user' => $user, 'label' => 'Library Card'])?>
    -
    +

    transEsc('Your Holds and Recalls') ?> (recordList ?? []);?>)

    noSupport)): ?> @@ -134,7 +135,7 @@
    record($resource)->renderTemplate('account-entry.phtml')?>
    -
    +
    transEsc('hold_requested_group') ?>: transEsc('request_group_' . $ilsDetails['requestGroup'], [], $this->transEscWithPrefix('location_', $ilsDetails['requestGroup']))?>
    @@ -242,6 +243,7 @@ +

    transEsc('End of List')?>

    cancelForm): ?>
    diff --git a/themes/finna2/templates/layout/layout.phtml b/themes/finna2/templates/layout/layout.phtml index fe51208e376..c81e20c1fc2 100644 --- a/themes/finna2/templates/layout/layout.phtml +++ b/themes/finna2/templates/layout/layout.phtml @@ -165,7 +165,9 @@ layout()->finnaMainHeader)) { + if (!empty($this->layout()->finnaUseraccountHeader)) { + $contentElementId = 'useraccount-content-header'; + } elseif (!empty($this->layout()->finnaMainHeader)) { $contentElementId = 'content-heading'; } elseif (!empty($this->layout()->finnaMainTabs)) { $contentElementId = 'content-main-tabs'; diff --git a/themes/finna2/templates/myresearch/checkedout.phtml b/themes/finna2/templates/myresearch/checkedout.phtml index 9a6ac1fab56..4396d1b0dad 100644 --- a/themes/finna2/templates/myresearch/checkedout.phtml +++ b/themes/finna2/templates/myresearch/checkedout.phtml @@ -2,6 +2,7 @@ headTitle($this->translate('Checked Out Items')); + $this->layout()->finnaUseraccountHeader = 'useraccount-content-header'; // Set up breadcrumbs: $this->layout()->breadcrumbs = '
  • ' . $this->transEsc('Your Account') . '
  • ' . $this->transEsc('Checked Out Items') . '
    • '; @@ -27,7 +28,7 @@
    context($this)->renderInContext('librarycards/selectcard.phtml', ['user' => $user, 'label' => 'Library Card'])?>
    -
    +

    transEsc('Your Checked Out Items')?> ()

    noSupport)): ?> @@ -176,7 +177,7 @@
    record($resource)->renderTemplate('account-entry.phtml', ['driver' => $resource, 'displayItemBarcode' => $this->displayItemBarcode])?>
    -
    +
    transEsc('onsite_checkout') ?>
    @@ -249,6 +250,7 @@ +

    transEsc('End of List')?>

    content()->findTemplateForLng('content/Additions/checkedout-post-list')): ?>
    render($template)?>
    diff --git a/themes/finna2/templates/myresearch/illrequests.phtml b/themes/finna2/templates/myresearch/illrequests.phtml index ae9cf56c529..7932fb97d41 100644 --- a/themes/finna2/templates/myresearch/illrequests.phtml +++ b/themes/finna2/templates/myresearch/illrequests.phtml @@ -2,6 +2,7 @@ headTitle($this->translate('Interlibrary Loan Requests')); + $this->layout()->finnaUseraccountHeader = 'useraccount-content-header'; // Set up breadcrumbs: $this->layout()->breadcrumbs = '
  • ' . $this->transEsc('Your Account') . '
    • ' @@ -21,7 +22,7 @@
    context($this)->renderInContext('librarycards/selectcard.phtml', ['user' => $user, 'label' => 'Library Card'])?>
    -
    +

    transEsc('Interlibrary Loan Requests') ?> (recordList ?? []);?>)

    noSupport)): ?> @@ -117,7 +118,7 @@ record($resource)->renderTemplate('account-entry.phtml')?> - + @@ -181,6 +182,7 @@ +

    transEsc('End of List')?>

    cancelForm): ?>
    diff --git a/themes/finna2/templates/myresearch/storageretrievalrequests.phtml b/themes/finna2/templates/myresearch/storageretrievalrequests.phtml index 9a62d6f407b..1551627fb29 100644 --- a/themes/finna2/templates/myresearch/storageretrievalrequests.phtml +++ b/themes/finna2/templates/myresearch/storageretrievalrequests.phtml @@ -2,6 +2,7 @@ headTitle($this->translate('Storage Retrieval Requests')); + $this->layout()->finnaUseraccountHeader = 'useraccount-content-header'; // Set up breadcrumbs: $this->layout()->breadcrumbs = '
  • ' . $this->transEsc('Your Account') . '
  • ' . $this->transEsc('Storage Retrieval Requests') . '
    • '; @@ -20,7 +21,7 @@
    context($this)->renderInContext('librarycards/selectcard.phtml', ['user' => $user, 'label' => 'Library Card'])?>
    -
    +

    transEsc('Storage Retrieval Requests') ?> (recordList ?? []);?>)

    noSupport)): ?> @@ -116,7 +117,7 @@ record($resource)->renderTemplate('account-entry.phtml')?> - + @@ -177,6 +178,7 @@ +

    transEsc('End of List')?>

    cancelForm): ?>
    From e6ceff15cde9ce97d3edcf9a0dfb4f2c057ec5a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Siiri=20Yl=C3=B6nen?= Date: Tue, 28 Jan 2025 09:49:22 +0200 Subject: [PATCH 3/8] Heading and skip link connections added as well as tabindex changes. --- themes/finna2/templates/checkouts/history.phtml | 2 +- themes/finna2/templates/holds/list.phtml | 2 +- themes/finna2/templates/librarycards/home.phtml | 5 +++-- themes/finna2/templates/myresearch/checkedout.phtml | 2 +- themes/finna2/templates/myresearch/fines.phtml | 7 ++++--- themes/finna2/templates/myresearch/illrequests.phtml | 2 +- .../templates/myresearch/storageretrievalrequests.phtml | 2 +- 7 files changed, 12 insertions(+), 10 deletions(-) diff --git a/themes/finna2/templates/checkouts/history.phtml b/themes/finna2/templates/checkouts/history.phtml index 07f1e724adc..9c3c0bd35a9 100644 --- a/themes/finna2/templates/checkouts/history.phtml +++ b/themes/finna2/templates/checkouts/history.phtml @@ -155,7 +155,7 @@ record($resource)->renderTemplate('account-entry.phtml')?> - + transEscWithPrefix('location_', $ilsDetails['institution_name'])?>
    diff --git a/themes/finna2/templates/holds/list.phtml b/themes/finna2/templates/holds/list.phtml index 95e6210c718..724c6ad306d 100755 --- a/themes/finna2/templates/holds/list.phtml +++ b/themes/finna2/templates/holds/list.phtml @@ -135,7 +135,7 @@
    record($resource)->renderTemplate('account-entry.phtml')?>
    -
    +
    transEsc('hold_requested_group') ?>: transEsc('request_group_' . $ilsDetails['requestGroup'], [], $this->transEscWithPrefix('location_', $ilsDetails['requestGroup']))?>
    diff --git a/themes/finna2/templates/librarycards/home.phtml b/themes/finna2/templates/librarycards/home.phtml index 356ac21b270..5355deb0afa 100644 --- a/themes/finna2/templates/librarycards/home.phtml +++ b/themes/finna2/templates/librarycards/home.phtml @@ -2,6 +2,7 @@ headTitle($this->translate('Library Cards')); + $this->layout()->finnaUseraccountHeader = 'useraccount-content-header'; // Set up breadcrumbs: $this->layout()->breadcrumbs = '
  • ' . $this->transEsc('Your Account') . '
  • ' . $this->transEsc('Library Cards') . '
    • '; @@ -19,13 +20,13 @@
    flashmessages()?> translationEmpty('library_cards_instructions_html')): ?>

    translate('library_cards_instructions_html')?>

    -
    +

    transEsc('Library Cards Connected To My Account')?>

    libraryCards)): ?>

    transEsc('You do not have any library cards')?>

    - +
    multipleTargets): ?> diff --git a/themes/finna2/templates/myresearch/checkedout.phtml b/themes/finna2/templates/myresearch/checkedout.phtml index 4396d1b0dad..92ae8a4bad0 100644 --- a/themes/finna2/templates/myresearch/checkedout.phtml +++ b/themes/finna2/templates/myresearch/checkedout.phtml @@ -177,7 +177,7 @@
    record($resource)->renderTemplate('account-entry.phtml', ['driver' => $resource, 'displayItemBarcode' => $this->displayItemBarcode])?>
    -
    +
    transEsc('onsite_checkout') ?>
    diff --git a/themes/finna2/templates/myresearch/fines.phtml b/themes/finna2/templates/myresearch/fines.phtml index 6c06c9c721c..44a734fbfa9 100644 --- a/themes/finna2/templates/myresearch/fines.phtml +++ b/themes/finna2/templates/myresearch/fines.phtml @@ -2,6 +2,7 @@ headTitle($this->translate('My Fines')); + $this->layout()->finnaUseraccountHeader = 'useraccount-content-header'; // Set up breadcrumbs: $this->layout()->breadcrumbs = '
  • ' . $this->transEsc('Your Account') . '
  • ' . $this->transEsc('Fines') . '
    • '; @@ -116,13 +117,13 @@
    context($this)->renderInContext('librarycards/selectcard.phtml', ['user' => $user, 'label' => 'Library Card'])?>
    -
    +

    transEsc('Your Fines') . ' (' . count($this->fines ?? []) . ')'?>

    flashmessages()?> partial('myresearch/borrowing-block.phtml', ['blocks' => $this->blocks]); ?> -
    +
    lastTransaction)): ?>
    @@ -234,7 +235,7 @@
    -
    transEsc('Library Card Name')?>
    +
    diff --git a/themes/finna2/templates/myresearch/illrequests.phtml b/themes/finna2/templates/myresearch/illrequests.phtml index 7932fb97d41..0f11ad60087 100644 --- a/themes/finna2/templates/myresearch/illrequests.phtml +++ b/themes/finna2/templates/myresearch/illrequests.phtml @@ -118,7 +118,7 @@ - -
    transEsc('Your Fines')?>
    record($resource)->renderTemplate('account-entry.phtml')?> + diff --git a/themes/finna2/templates/myresearch/storageretrievalrequests.phtml b/themes/finna2/templates/myresearch/storageretrievalrequests.phtml index 1551627fb29..015d276df61 100644 --- a/themes/finna2/templates/myresearch/storageretrievalrequests.phtml +++ b/themes/finna2/templates/myresearch/storageretrievalrequests.phtml @@ -117,7 +117,7 @@ record($resource)->renderTemplate('account-entry.phtml')?> + From 86636b817a5dda7080d1a54e13d9ea155bf2aa0c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Siiri=20Yl=C3=B6nen?= Date: Tue, 28 Jan 2025 10:33:38 +0200 Subject: [PATCH 4/8] Add rest of the skip links to account page title. --- themes/finna2/templates/myresearch/mylist.phtml | 3 ++- themes/finna2/templates/myresearch/profile.phtml | 3 ++- themes/finna2/templates/search/history-table.phtml | 2 +- themes/finna2/templates/search/history.phtml | 5 +++-- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/themes/finna2/templates/myresearch/mylist.phtml b/themes/finna2/templates/myresearch/mylist.phtml index 157ec336664..1ae06c1ce71 100644 --- a/themes/finna2/templates/myresearch/mylist.phtml +++ b/themes/finna2/templates/myresearch/mylist.phtml @@ -5,6 +5,7 @@ // Set up page title: $this->headTitle($list ? $list->getTitle() : $this->translate('saved_items')); + $this->layout()->finnaUseraccountHeader = 'useraccount-content-header'; // Set up breadcrumbs: $currPage = $list ? 'List' : 'saved_items'; @@ -49,7 +50,7 @@
    -
    +

    transEsc('saved_items')?>

    diff --git a/themes/finna2/templates/myresearch/profile.phtml b/themes/finna2/templates/myresearch/profile.phtml index e02fd98ff5f..493b7c5ef0c 100644 --- a/themes/finna2/templates/myresearch/profile.phtml +++ b/themes/finna2/templates/myresearch/profile.phtml @@ -2,6 +2,7 @@ headTitle($this->translate('My Profile')); + $this->layout()->finnaUseraccountHeader = 'useraccount-content-header'; // Set up breadcrumbs: $this->layout()->breadcrumbs = '
  • ' . $this->transEsc('Your Account') . '
  • ' . $this->transEsc('Profile') . '
    • '; // Only display home library form if we have multiple pickup locations: @@ -44,7 +45,7 @@ context($this)->renderInContext('myresearch/menu.phtml', ['active' => 'profile']); ?>
    -
    +

    transEsc('Profile')?>

    diff --git a/themes/finna2/templates/search/history-table.phtml b/themes/finna2/templates/search/history-table.phtml index 24f22cb3279..ca1cc64aee8 100644 --- a/themes/finna2/templates/search/history-table.phtml +++ b/themes/finna2/templates/search/history-table.phtml @@ -17,7 +17,7 @@ } } ?> - +
    diff --git a/themes/finna2/templates/search/history.phtml b/themes/finna2/templates/search/history.phtml index eae5c16335e..209d42cffc9 100644 --- a/themes/finna2/templates/search/history.phtml +++ b/themes/finna2/templates/search/history.phtml @@ -2,6 +2,7 @@ headTitle($this->translate('Search History')); + $this->layout()->finnaUseraccountHeader = 'useraccount-content-header'; $saveSupported = $this->accountCapabilities()->getSavedSearchSetting() === 'enabled'; $loggedInUser = $this->auth()->getUserObject(); @@ -47,7 +48,7 @@ flashmessages();?> -
    +

    transEsc('history_saved_searches')?>

    saved)): ?> @@ -61,7 +62,7 @@ -
    +

    transEsc('history_recent_searches')?>

    unsaved)): ?> From 75b677fd54f4a51266a6b507da15a448701fa2ea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Siiri=20Yl=C3=B6nen?= Date: Wed, 29 Jan 2025 13:06:07 +0200 Subject: [PATCH 5/8] Fix/clarify add new list for screen reader and remove role. --- themes/finna2/js/finna-mylist.js | 8 ++++---- themes/finna2/scss/finna/mylist.scss | 8 +++++++- themes/finna2/templates/myresearch/menu.phtml | 4 ++-- themes/finna2/templates/myresearch/mylist-navi.phtml | 2 +- 4 files changed, 14 insertions(+), 8 deletions(-) diff --git a/themes/finna2/js/finna-mylist.js b/themes/finna2/js/finna-mylist.js index 3add910b724..1df882ed21d 100644 --- a/themes/finna2/js/finna-mylist.js +++ b/themes/finna2/js/finna-mylist.js @@ -347,7 +347,7 @@ finna.myList = (function finnaMyList() { }); } - $('.add-new-list .icon').on('click', function createNewList() { + $('#add-new-list-item-btn').on('click', function createNewList() { var newListInput = $('.new-list-input'); var newListName = newListInput.val().trim(); @@ -358,10 +358,10 @@ finna.myList = (function finnaMyList() { } }); - //Add new list, listen for keyup enter + //Add new list, listen for keyup enter or space $('.new-list-input').on('keyup', function invokeCreateNewList(e) { - if (e.keyCode === 13) { - $('.add-new-list .icon').trigger("click"); + if (e.which === 13 || e.which === 32) { + $('#add-new-list-item-btn').trigger("click"); } }); diff --git a/themes/finna2/scss/finna/mylist.scss b/themes/finna2/scss/finna/mylist.scss index 4d765bb9ea3..06b5330b252 100644 --- a/themes/finna2/scss/finna/mylist.scss +++ b/themes/finna2/scss/finna/mylist.scss @@ -119,6 +119,12 @@ .add-new-list-holder { padding: 0 20px; margin: 5px 0 10px 0px; + #add-new-list-item-btn { + border: none; + &:not(:hover){ + background: none; + } + } .add-new-list { border: 1px solid $gray-lighter; display: -webkit-flex; @@ -138,7 +144,7 @@ } } .list-add-icon { - text-align: right; + text-align: center; width: 20px; cursor: pointer; color: $action-link-color; diff --git a/themes/finna2/templates/myresearch/menu.phtml b/themes/finna2/templates/myresearch/menu.phtml index a210eb7fdb3..6378b32340f 100644 --- a/themes/finna2/templates/myresearch/menu.phtml +++ b/themes/finna2/templates/myresearch/menu.phtml @@ -167,7 +167,7 @@ ?>
  • -
  • - icon('list-add', 'list-add-icon') ?> +
    • From 5926433db54d1646c1e2876d6a197f799cd94f03 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Siiri=20Yl=C3=B6nen?= Date: Wed, 29 Jan 2025 13:31:51 +0200 Subject: [PATCH 6/8] Skip to link to work on all lists page too. --- themes/finna2/templates/myresearch/mylist.phtml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/themes/finna2/templates/myresearch/mylist.phtml b/themes/finna2/templates/myresearch/mylist.phtml index 1ae06c1ce71..f916a104e6f 100644 --- a/themes/finna2/templates/myresearch/mylist.phtml +++ b/themes/finna2/templates/myresearch/mylist.phtml @@ -44,13 +44,13 @@ -
    +
    flashmessages()?>
    -
    +

    transEsc('saved_items')?>

    From 0def60eecffa8795ae56888f2af7d524a898f048 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Siiri=20Yl=C3=B6nen?= Date: Wed, 29 Jan 2025 13:47:17 +0200 Subject: [PATCH 7/8] Fix the thought mistake in keyup function and which element is connected. --- themes/finna2/js/finna-mylist.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/themes/finna2/js/finna-mylist.js b/themes/finna2/js/finna-mylist.js index 1df882ed21d..46970cd84cd 100644 --- a/themes/finna2/js/finna-mylist.js +++ b/themes/finna2/js/finna-mylist.js @@ -357,10 +357,15 @@ finna.myList = (function finnaMyList() { updateList({'id': 'NEW', 'title': newListName, 'desc': null, 'public': 0}, newListAdded, 'add-list'); } }); + $('#add-new-list-item-btn').on('keyup', function invokeCreateNewList(e) { + if (e.keyCode === 32) { + $('#add-new-list-item-btn').trigger("click"); + } + }); - //Add new list, listen for keyup enter or space + //Add new list, listen for keyup enter $('.new-list-input').on('keyup', function invokeCreateNewList(e) { - if (e.which === 13 || e.which === 32) { + if (e.keyCode === 13) { $('#add-new-list-item-btn').trigger("click"); } }); From 35694e0661cfe2ed71cbdb3944e96e161f4940a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Siiri=20Yl=C3=B6nen?= Date: Fri, 31 Jan 2025 10:37:14 +0200 Subject: [PATCH 8/8] se translation added. --- local/languages/finna/se.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/local/languages/finna/se.ini b/local/languages/finna/se.ini index 00e5b52b435..899cd4f69eb 100644 --- a/local/languages/finna/se.ini +++ b/local/languages/finna/se.ini @@ -308,6 +308,7 @@ embedded_content_description = "Dát sisdoallu boahtá čujuhusas %%serviceBaseU embedded_content_external_link = "Sirdás olgguldas siidduide" embedded_content_heading = "Sisdoallu ii sáhte čájehuvvot" Empty Book Bag = "Gurre" +End of List = "Listtu loahppa" Ensembles = "Čoakkádusat" Era = "Fáttá áigi" Established = "Vuođđuduvvon"
    transEsc('history_time')?>